[GitHub] [incubator-hudi] hmatu commented on issue #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
hmatu commented on issue #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-580693541 > > @bvaradar Operation type is stored in the avro objects when archiving, but there are a error here, it throw `ClassCastException: org.apache.avro.generic.GenericData$EnumSymbol cannot be cast to org.apache.hudi.avro.model.WriteOperationType` with `deepCopy` block in 'show archived commit stats' . Can you give any suggestion when you're free. > > @bvaradar I found it cause by [AVRO-1676](https://issues.apache.org/jira/browse/AVRO-1676) and fixed in AVRO-1.8.0. So can i roll back `operationType ` to String type? It may cause other compatibility problem If upgrade avro. Already using `avro-1.8.2` dependency, String type is redundant now. https://github.com/apache/incubator-hudi/blob/f27c7a16c6d437efaa83e50a7117b83e5201ac49/pom.xml#L96 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
hmatu commented on issue #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-572835965 IMO, `WriteOperationType` duplicate to `OperationType`, keep one is a better way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
hmatu commented on issue #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-569622110 @hddong can you explain why add operation type to HoodieCommitMetadata? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
