[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-21 Thread GitBox
nsivabalan commented on a change in pull request #1433: URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r428954499 ## File path: hudi-spark/src/test/java/org/apache/hudi/keygen/TestSimpleKeyGenerator.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-21 Thread GitBox
nsivabalan commented on a change in pull request #1433: URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r428953503 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-17 Thread GitBox
nsivabalan commented on a change in pull request #1433: URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r426313249 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-17 Thread GitBox
nsivabalan commented on a change in pull request #1433: URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r426313186 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-14 Thread GitBox
nsivabalan commented on a change in pull request #1433: URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r425547719 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/SimpleKeyGenerator.java ## @@ -66,6 +68,14 @@ public HoodieKey

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-03-30 Thread GitBox
nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r400521746 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-03-30 Thread GitBox
nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r400521994 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-03-30 Thread GitBox
nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r400521890 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-03-30 Thread GitBox
nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r400516294 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator

2020-03-30 Thread GitBox
nsivabalan commented on a change in pull request #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r400516907 ## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java ## @@