[GitHub] [incubator-hudi] nsivabalan commented on pull request #1402: [HUDI-407] Adding Simple Index

2020-05-15 Thread GitBox 


nsivabalan commented on pull request #1402:
URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-629558212


   Squashed all commits to one @vinothchandar 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] nsivabalan commented on pull request #1402: [HUDI-407] Adding Simple Index

2020-05-14 Thread GitBox 


nsivabalan commented on pull request #1402:
URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-628997531


   @vinothchandar : tests are passing. Let me know if you want me to squash all 
commits



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] nsivabalan commented on pull request #1402: [HUDI-407] Adding Simple Index

2020-05-02 Thread GitBox 


nsivabalan commented on pull request #1402:
URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-623006320


   @lamber-ken : looks like visibleForTesting is part of illegal import. So, do 
you know of a way to whats to test private methods? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] nsivabalan commented on pull request #1402: [HUDI-407] Adding Simple Index

2020-04-29 Thread GitBox 


nsivabalan commented on pull request #1402:
URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-621225622


   @vinothchandar : have addressed your comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] nsivabalan commented on pull request #1402: [HUDI-407] Adding Simple Index

2020-04-27 Thread GitBox 


nsivabalan commented on pull request #1402:
URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-620243226


   > @nsivabalan is this still WIP.. please remove the prefix if its ready
   
   done. it is ready. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org