[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #780: Fixes HUDI-172 : Cleanup Maven POM/Classpath

2019-07-17 Thread GitBox 
vinothchandar commented on a change in pull request #780: Fixes HUDI-172 : 
Cleanup Maven POM/Classpath
URL: https://github.com/apache/incubator-hudi/pull/780#discussion_r304692830
 
 

 ##
 File path: hoodie-integ-test/pom.xml
 ##
 @@ -43,69 +70,47 @@
   test-jar
   test
 
-
-  org.awaitility
-  awaitility
-  3.1.2
-  test
-
 
   com.uber.hoodie
   hoodie-spark
   ${project.version}
   tests
   test-jar
   test
-  
-
-  org.glassfish.**
-  *
-
-  
-
-
-  com.google.guava
-  guava
-  20.0
-  test
 
+
+
 
   com.fasterxml.jackson.core
   jackson-annotations
-  2.6.4
   test
 
 
   com.fasterxml.jackson.core
   jackson-databind
-  2.6.4
   test
 
 
   com.fasterxml.jackson.datatype
   jackson-datatype-guava
-  2.9.4
+  ${fasterxml.version}
 
 Review comment:
   can't we inherit from parent like usual? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #780: Fixes HUDI-172 : Cleanup Maven POM/Classpath

2019-07-17 Thread GitBox 
vinothchandar commented on a change in pull request #780: Fixes HUDI-172 : 
Cleanup Maven POM/Classpath
URL: https://github.com/apache/incubator-hudi/pull/780#discussion_r302762896
 
 

 ##
 File path: hoodie-cli/pom.xml
 ##
 @@ -159,67 +176,51 @@
   spark-sql_2.11
 
 
+
 
-  com.jakewharton.fliptables
-  fliptables
-  1.0.2
+  commons-dbcp
+  commons-dbcp
 
 
 
-  log4j
-  log4j
-  ${log4j.version}
+  org.springframework.shell
+  spring-shell
+  ${spring.shell.version}
 
 
 
-  com.uber.hoodie
-  hoodie-hive
-  ${project.version}
+  de.vandermeer
+  asciitable
+  0.2.5
 
 
 
-  com.uber.hoodie
-  hoodie-client
-  ${project.version}
+  com.jakewharton.fliptables
+  fliptables
+  1.0.2
 
 
+
+  joda-time
+  joda-time
 
 Review comment:
   removed version


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #780: Fixes HUDI-172 : Cleanup Maven POM/Classpath

2019-07-17 Thread GitBox 
vinothchandar commented on a change in pull request #780: Fixes HUDI-172 : 
Cleanup Maven POM/Classpath
URL: https://github.com/apache/incubator-hudi/pull/780#discussion_r302763536
 
 

 ##
 File path: hoodie-client/pom.xml
 ##
 @@ -78,6 +79,71 @@
   hoodie-timeline-service
   ${project.version}
 
+
+
+
+  log4j
+  log4j
+
+
+
+
+  org.apache.parquet
+  parquet-avro
+
+
+  org.apache.parquet
 
 Review comment:
   removed already


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services