vinothchandar commented on a change in pull request #793: Allow
HoodieWrapperFileSystem to wrap other proxy file-system implementations with no
getScheme implementation
URL: https://github.com/apache/incubator-hudi/pull/793#discussion_r304344989
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/io/storage/HoodieWrapperFileSystem.java
##########
@@ -121,13 +121,15 @@ public void initialize(URI uri, Configuration conf)
throws IOException {
// Remove 'hoodie-' prefix from path
if (path.toString().startsWith(HOODIE_SCHEME_PREFIX)) {
path = new Path(path.toString().replace(HOODIE_SCHEME_PREFIX, ""));
+ this.uri = path.toUri();
+ } else {
+ this.uri = uri;
}
this.fileSystem = FSUtils.getFs(path.toString(), conf);
// Do not need to explicitly initialize the default filesystem, its done
already in the above
Review comment:
do we clean up lines 127-129?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
