[GitHub] [incubator-hudi] vinothchandar commented on issue #1430: [hotfix] Improve code quality of HoodieAvroWriteSupport

2020-03-21 Thread GitBox
vinothchandar commented on issue #1430: [hotfix] Improve code quality of 
HoodieAvroWriteSupport
URL: https://github.com/apache/incubator-hudi/pull/1430#issuecomment-602001089
 
 
   @TisonKun thanks! if you are looking for newbie bugs, there are some tagged 
on JIRA 
   
   
https://issues.apache.org/jira/issues/?jql=project%20%3D%20HUDI%20AND%20component%20%3D%20newbie
 
   
   you can also look at issues tagged with `Code Cleanup` and `Testing`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] vinothchandar commented on issue #1430: [hotfix] Improve code quality of HoodieAvroWriteSupport

2020-03-20 Thread GitBox
vinothchandar commented on issue #1430: [hotfix] Improve code quality of 
HoodieAvroWriteSupport
URL: https://github.com/apache/incubator-hudi/pull/1430#issuecomment-601993412
 
 
   @TisonKun can you please follow the contribution guide where we suggest 
filing a JIRA and getting this signed off by a committer first.
   
   There is no hotfix prefix we support for PRs and this IMO is not a hotfix.. 
the change itself I am not sure improves the code. Templatizing to  is 
not very useful IMO 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services