[GitHub] [incubator-hudi] vinothchandar commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
vinothchandar commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-632774712 @xushiyan may be we need to doc this or write a small post? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
vinothchandar commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-632774153 Sorry folks.. Got delayed .. This looks fine at a high level.. I was mulling if using http-client directly will cause any issues for us.. but seems ok.. If something comes up, we can fix forward.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
vinothchandar commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-625049202 @xushiyan I think the metrics tests are hard coding the ports and running into issues? I ran into one such issue locally.. PR brewing.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
vinothchandar commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-624504748 @xushiyan absolutely... please go ahead! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
