[GitHub] [incubator-hudi] xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic
xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-603626530 @leesf Please kindly review the last commit for the commented testcases. Note that I omitted the `assertFalse(dfs.exists(new Path(targetPath)));` statement; figure it is ok as we obviously don't expect that when exception was thrown. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic
xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602231025 @leesf Changed to `JavaSparkContext` in the last commit. Please kindly review. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic
xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602121223 @leesf @vinothchandar To align with other utility tools, I'd also like to pass `JavaSparkContext` instead of `SparkSession` to the main, sounds good? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
