[GitHub] [incubator-hudi] xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer
xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer URL: https://github.com/apache/incubator-hudi/pull/1440#issuecomment-607291746 @vinothchandar @yanghua Please check the last commit and merge if it's ok. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer
xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer URL: https://github.com/apache/incubator-hudi/pull/1440#issuecomment-605593208 @yanghua @vinothchandar please check the last commit for the rework. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer
xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer URL: https://github.com/apache/incubator-hudi/pull/1440#issuecomment-603417382 @vinothchandar @yanghua Sure thanks for the input. Since the parsing approach saves some efforts for users, I can make it that way. May I have your 👍 on this comment to get the green light to work on it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer
xushiyan commented on issue #1440: [HUDI-731] Add ChainedTransformer URL: https://github.com/apache/incubator-hudi/pull/1440#issuecomment-603012975 @vinothchandar The current approach is also compatible with existing CLI usage. The user extends this abstract class and plugs that custom class to `--transformer-class` param. So the difference is: transformer list is supplied from user's code instead of being parsed from CLI args. My reasoning for this implementation is: it saves some parsing logic to maintain and users could have more flexibility in how they supply transformers (via their own code). Though saying that, I don't mind making the transformers parsed from CLI. It's kinda user experience trade-off. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
