[GitHub] [incubator-hudi] yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

2020-02-10 Thread GitBox
yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named 
hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314#issuecomment-584014077
 
 
   > @yanghua ack. Do we need a feature branch for this work? can't we do this 
on master with incremental commits
   
   A new module will be added here. If we copy related class files from 
`hudi-client` to the new module instead of moving those class files. it can 
theoretically be completed on the master branch
   
   However, as a relatively large work (we will eventually move some classes in 
the `hubi-client` to other modules), it will be more reasonable to verify it on 
an independent branch to see whether those PRs can pass then migrate them to 
the master branch, which will not affect the master branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

2020-02-08 Thread GitBox
yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named 
hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314#issuecomment-583715237
 
 
   @vinothchandar @leesf FYI: new module `hudi-writer-common` on 
`restructure-hudi-client`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services