[jira] [Comment Edited] (HUDI-365) Refactor hudi-cli based on new ImportOrder code style rule

2019-12-03 Thread lamber-ken (Jira)


[ 
https://issues.apache.org/jira/browse/HUDI-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986873#comment-16986873
 ] 

lamber-ken edited comment on HUDI-365 at 12/3/19 1:00 PM:
--

hi, [~gurudatt], some tips may help you to work skillfully. The new ImportOrder 
rule split import statements into groups and groups are separated by one blank 
line. These groups are 1) org.apache.hudi   2) third party imports   3) javax   
4) java   5) static

!image-2019-12-03-20-58-20-503.png!

 

 


was (Author: lamber-ken):
hi, [~gurudatt], some tips may help you to work quickly. The new ImportOrder 
rule split import statements into groups and groups are separated by one blank 
line. These groups are 1) org.apache.hudi   2) third party imports   3) javax   
4) java   5) static

!image-2019-12-03-20-58-20-503.png!




 

 

> Refactor hudi-cli based on new ImportOrder code style rule
> --
>
> Key: HUDI-365
> URL: https://issues.apache.org/jira/browse/HUDI-365
> Project: Apache Hudi (incubating)
>  Issue Type: Sub-task
>Reporter: Gurudatt Kulkarni
>Assignee: Gurudatt Kulkarni
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2019-12-03-20-58-20-503.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HUDI-365) Refactor hudi-cli based on new ImportOrder code style rule

2019-12-03 Thread lamber-ken (Jira)


[ 
https://issues.apache.org/jira/browse/HUDI-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986793#comment-16986793
 ] 

lamber-ken edited comment on HUDI-365 at 12/3/19 11:02 AM:
---

hello, [~gurudatt], are you still working on this? the hudi-cli is the last one 
module which needs to refactor for ImportOrder code style rule. After this 
work, we can set severity to error. :):):)

If you don't have time to refactor, I'm happy to help you to finish this one.


was (Author: lamber-ken):
hello, [~gurudatt], are you still working on this? the hudi-cli is the last one 
module which needs to refactor for ImportOrder code style rule. After this 
work, we can set severity to error. :):):)

> Refactor hudi-cli based on new ImportOrder code style rule
> --
>
> Key: HUDI-365
> URL: https://issues.apache.org/jira/browse/HUDI-365
> Project: Apache Hudi (incubating)
>  Issue Type: Sub-task
>Reporter: Gurudatt Kulkarni
>Assignee: Gurudatt Kulkarni
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HUDI-365) Refactor hudi-cli based on new ImportOrder code style rule

2019-12-03 Thread lamber-ken (Jira)


[ 
https://issues.apache.org/jira/browse/HUDI-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986793#comment-16986793
 ] 

lamber-ken edited comment on HUDI-365 at 12/3/19 11:00 AM:
---

hello, [~gurudatt], are you still working on this? the hudi-cli is the last one 
module which needs to refactor for ImportOrder code style rule. After this 
work, we can set severity to error. :):):)


was (Author: lamber-ken):
hello, [~gurudatt], are you still working on this? the hudi-cli is the lastest 
module which needs to refactor for ImportOrder code style rule. After this 
work, we can set severity to error. :):):)

> Refactor hudi-cli based on new ImportOrder code style rule
> --
>
> Key: HUDI-365
> URL: https://issues.apache.org/jira/browse/HUDI-365
> Project: Apache Hudi (incubating)
>  Issue Type: Sub-task
>Reporter: Gurudatt Kulkarni
>Assignee: Gurudatt Kulkarni
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)