[jira] [Updated] (HUDI-751) Fix some coding issues reported by FindBugs

2020-03-31 Thread vinoyang (Jira)


 [ 
https://issues.apache.org/jira/browse/HUDI-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vinoyang updated HUDI-751:
--
Status: Open  (was: New)

> Fix some coding issues reported by FindBugs
> ---
>
> Key: HUDI-751
> URL: https://issues.apache.org/jira/browse/HUDI-751
> Project: Apache Hudi (incubating)
>  Issue Type: Improvement
>Reporter: Shao Feng Shi
>Assignee: Shao Feng Shi
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When I go through the code base, the FindBugs plugin in my IDEA reports 
> several issues, such as
> 1) Class implement "Serializable" doesn't have a "serialVersionUID";
> 2) Inner class wasn't declared as static;
> 3) Some static constant variables were not marked as final;
> 4) Some variable doesn't follow the naming convention, etc;
> 5) JDBC Connection resource wasn't closed after using;
>  
> I fixed them quickly, and will raise a pull request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HUDI-751) Fix some coding issues reported by FindBugs

2020-03-31 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HUDI-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HUDI-751:

Labels: pull-request-available  (was: )

> Fix some coding issues reported by FindBugs
> ---
>
> Key: HUDI-751
> URL: https://issues.apache.org/jira/browse/HUDI-751
> Project: Apache Hudi (incubating)
>  Issue Type: Improvement
>Reporter: Shao Feng Shi
>Priority: Major
>  Labels: pull-request-available
>
> When I go through the code base, the FindBugs plugin in my IDEA reports 
> several issues, such as
> 1) Class implement "Serializable" doesn't have a "serialVersionUID";
> 2) Inner class wasn't declared as static;
> 3) Some static constant variables were not marked as final;
> 4) Some variable doesn't follow the naming convention, etc;
> 5) JDBC Connection resource wasn't closed after using;
>  
> I fixed them quickly, and will raise a pull request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HUDI-751) Fix some coding issues reported by FindBugs

2020-03-30 Thread Shao Feng Shi (Jira)


 [ 
https://issues.apache.org/jira/browse/HUDI-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shao Feng Shi updated HUDI-751:
---
Description: 
When I go through the code base, the FindBugs plugin in my IDEA reports several 
issues, such as

1) Class implement "Serializable" doesn't have a "serialVersionUID";

2) Inner class wasn't declared as static;

3) Some static constant variables were not marked as final;

4) Some variable doesn't follow the naming convention, etc;

5) JDBC Connection resource wasn't closed after using;

 

I fixed them quickly, and will raise a pull request.

  was:
When I go through the code base, the FindBugs plugin in my IDEA reports several 
issues, such as

1) Class implement "Serializable" doesn't have a "serialVersionUID";

2) Inner class wasn't declared as static;

3) Some static constant variables were not marked as final;

4) Some variable doesn't follow the naming convention, etc;

 

I fixed them quickly, and will raise a pull request.


> Fix some coding issues reported by FindBugs
> ---
>
> Key: HUDI-751
> URL: https://issues.apache.org/jira/browse/HUDI-751
> Project: Apache Hudi (incubating)
>  Issue Type: Improvement
>Reporter: Shao Feng Shi
>Priority: Major
>
> When I go through the code base, the FindBugs plugin in my IDEA reports 
> several issues, such as
> 1) Class implement "Serializable" doesn't have a "serialVersionUID";
> 2) Inner class wasn't declared as static;
> 3) Some static constant variables were not marked as final;
> 4) Some variable doesn't follow the naming convention, etc;
> 5) JDBC Connection resource wasn't closed after using;
>  
> I fixed them quickly, and will raise a pull request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)