IGNITE-2220 Review.
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/8d0f2b04 Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/8d0f2b04 Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/8d0f2b04 Branch: refs/heads/ignite-843-rc2 Commit: 8d0f2b04b3ed249cb3c32241f64b4dc4a64ded60 Parents: 6b110a8 Author: Andrey <anovi...@gridgain.com> Authored: Wed Dec 23 16:19:41 2015 +0700 Committer: Andrey <anovi...@gridgain.com> Committed: Wed Dec 23 16:22:10 2015 +0700 ---------------------------------------------------------------------- modules/control-center-web/src/main/js/.eslintrc | 2 +- .../app/directives/ui-ace-java/ui-ace-java.controller.js | 2 +- .../directives/ui-ace-pojos/ui-ace-pojos.controller.js | 10 +++++----- .../js/app/directives/ui-ace-pom/ui-ace-pom.controller.js | 2 +- .../js/app/directives/ui-ace-xml/ui-ace-xml.controller.js | 2 +- .../src/main/js/app/filters/hasPojo/hasPojo.filter.js | 2 +- .../src/main/js/app/modules/Auth/index.js | 2 +- .../main/js/app/modules/Form/field/dropdown.directive.js | 4 ++-- .../js/app/modules/Form/field/input/number.directive.js | 2 +- .../src/main/js/app/modules/dialog/dialog.factory.js | 2 +- .../states/configuration/summary/summary.controller.js | 4 ++-- .../states/configuration/summary/summary.resource.js | 4 ++-- .../src/main/js/app/services/UiAceOnLoad/service.js | 2 +- .../src/main/js/gulpfile.js/tasks/eslint.js | 2 +- 14 files changed, 21 insertions(+), 21 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/.eslintrc ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/.eslintrc b/modules/control-center-web/src/main/js/.eslintrc index 074ecf4..9e96771 100644 --- a/modules/control-center-web/src/main/js/.eslintrc +++ b/modules/control-center-web/src/main/js/.eslintrc @@ -31,7 +31,7 @@ globals: saveAs: true rules: - arrow-parens: [1, "as-needed"] + arrow-parens: [1, "always"] arrow-spacing: [1, { "before": true, "after": true }] accessor-pairs: 2 block-scoped-var: 2 http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/directives/ui-ace-java/ui-ace-java.controller.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/directives/ui-ace-java/ui-ace-java.controller.js b/modules/control-center-web/src/main/js/app/directives/ui-ace-java/ui-ace-java.controller.js index fbdbbd7..56e0cf3 100644 --- a/modules/control-center-web/src/main/js/app/directives/ui-ace-java/ui-ace-java.controller.js +++ b/modules/control-center-web/src/main/js/app/directives/ui-ace-java/ui-ace-java.controller.js @@ -25,7 +25,7 @@ export default ['$scope', 'IgniteUiAceOnLoad', function($scope, onLoad) { $scope.onLoad = onLoad; // Watchers definition. - const clusterWatcher = value => { + const clusterWatcher = (value) => { delete ctrl.data; if (!value) http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/directives/ui-ace-pojos/ui-ace-pojos.controller.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/directives/ui-ace-pojos/ui-ace-pojos.controller.js b/modules/control-center-web/src/main/js/app/directives/ui-ace-pojos/ui-ace-pojos.controller.js index 23b58be..91857d3 100644 --- a/modules/control-center-web/src/main/js/app/directives/ui-ace-pojos/ui-ace-pojos.controller.js +++ b/modules/control-center-web/src/main/js/app/directives/ui-ace-pojos/ui-ace-pojos.controller.js @@ -41,7 +41,7 @@ export default ['$scope', 'IgniteUiAceOnLoad', function($scope, onLoad) { }; // Watcher update classes after - const updateClasses = value => { + const updateClasses = (value) => { delete ctrl.classes; if (!value) @@ -49,14 +49,14 @@ export default ['$scope', 'IgniteUiAceOnLoad', function($scope, onLoad) { const classes = ctrl.classes = []; - _.forEach(ctrl.metadatas, meta => { + _.forEach(ctrl.metadatas, (meta) => { classes.push(meta.keyType); classes.push(meta.valueType); }); }; // Update pojos class. - const updateClass = value => { + const updateClass = (value) => { if (!value || !ctrl.metadatas.length) return; @@ -64,11 +64,11 @@ export default ['$scope', 'IgniteUiAceOnLoad', function($scope, onLoad) { }; // Update pojos data. - const updatePojosData = value => { + const updatePojosData = (value) => { if (!value) return; - _.forEach(ctrl.metadatas, meta => { + _.forEach(ctrl.metadatas, (meta) => { if (meta.keyType === ctrl.class) return ctrl.data = meta.keyClass; http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/directives/ui-ace-pom/ui-ace-pom.controller.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/directives/ui-ace-pom/ui-ace-pom.controller.js b/modules/control-center-web/src/main/js/app/directives/ui-ace-pom/ui-ace-pom.controller.js index 37b7cd2..72b0b30 100644 --- a/modules/control-center-web/src/main/js/app/directives/ui-ace-pom/ui-ace-pom.controller.js +++ b/modules/control-center-web/src/main/js/app/directives/ui-ace-pom/ui-ace-pom.controller.js @@ -25,7 +25,7 @@ export default ['$scope', 'IgniteUiAceOnLoad', function($scope, onLoad) { $scope.onLoad = onLoad; // Watchers definition. - const clusterWatcher = value => { + const clusterWatcher = (value) => { delete ctrl.data; if (!value) http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/directives/ui-ace-xml/ui-ace-xml.controller.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/directives/ui-ace-xml/ui-ace-xml.controller.js b/modules/control-center-web/src/main/js/app/directives/ui-ace-xml/ui-ace-xml.controller.js index 2bfb7d8..2fb7397 100644 --- a/modules/control-center-web/src/main/js/app/directives/ui-ace-xml/ui-ace-xml.controller.js +++ b/modules/control-center-web/src/main/js/app/directives/ui-ace-xml/ui-ace-xml.controller.js @@ -22,7 +22,7 @@ export default ['$scope', 'IgniteUiAceOnLoad', function($scope, onLoad) { $scope.onLoad = onLoad; // Watchers definition. - const clusterWatcher = value => { + const clusterWatcher = (value) => { delete ctrl.data; if (!value) http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/filters/hasPojo/hasPojo.filter.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/filters/hasPojo/hasPojo.filter.js b/modules/control-center-web/src/main/js/app/filters/hasPojo/hasPojo.filter.js index 0cf28f4..559c433 100644 --- a/modules/control-center-web/src/main/js/app/filters/hasPojo/hasPojo.filter.js +++ b/modules/control-center-web/src/main/js/app/filters/hasPojo/hasPojo.filter.js @@ -16,7 +16,7 @@ */ export default ['hasPojo', [() => { - const filter = cache => { + const filter = (cache) => { return cache.metadatas && cache.metadatas.length; }; http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/modules/Auth/index.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/modules/Auth/index.js b/modules/control-center-web/src/main/js/app/modules/Auth/index.js index 542adb1..fddf8eb 100644 --- a/modules/control-center-web/src/main/js/app/modules/Auth/index.js +++ b/modules/control-center-web/src/main/js/app/modules/Auth/index.js @@ -50,7 +50,7 @@ angular auth(action, userInfo) { $http.post('/api/v1/' + action, userInfo) .then(User.read) - .then(user => { + .then((user) => { if (action !== 'password/forgot') { _authorized(true); http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/modules/Form/field/dropdown.directive.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/modules/Form/field/dropdown.directive.js b/modules/control-center-web/src/main/js/app/modules/Form/field/dropdown.directive.js index d5244cf..8bf636c 100644 --- a/modules/control-center-web/src/main/js/app/modules/Form/field/dropdown.directive.js +++ b/modules/control-center-web/src/main/js/app/modules/Form/field/dropdown.directive.js @@ -17,8 +17,8 @@ import template from './dropdown.jade!'; -export default ['igniteFormFieldDropdown', ['IgniteFormGUID', guid => { - const link = scope => { +export default ['igniteFormFieldDropdown', ['IgniteFormGUID', (guid) => { + const link = (scope) => { const {id} = scope; scope.id = id || guid(); http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/modules/Form/field/input/number.directive.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/modules/Form/field/input/number.directive.js b/modules/control-center-web/src/main/js/app/modules/Form/field/input/number.directive.js index 2bb37e0..f06e189 100644 --- a/modules/control-center-web/src/main/js/app/modules/Form/field/input/number.directive.js +++ b/modules/control-center-web/src/main/js/app/modules/Form/field/input/number.directive.js @@ -17,7 +17,7 @@ import template from './number.jade!'; -export default ['igniteFormFieldInputNumber', ['IgniteFormGUID', guid => { +export default ['igniteFormFieldInputNumber', ['IgniteFormGUID', (guid) => { const link = (scope, el, attrs, [form, label]) => { const {id, name} = scope; const field = form[name]; http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/modules/dialog/dialog.factory.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/modules/dialog/dialog.factory.js b/modules/control-center-web/src/main/js/app/modules/dialog/dialog.factory.js index 756451d..18a2174 100644 --- a/modules/control-center-web/src/main/js/app/modules/dialog/dialog.factory.js +++ b/modules/control-center-web/src/main/js/app/modules/dialog/dialog.factory.js @@ -17,7 +17,7 @@ import template from './dialog.jade!'; -export default ['IgniteDialog', ['$modal', $modal => { +export default ['IgniteDialog', ['$modal', ($modal) => { const defaults = { template: template(), placement: 'center', http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.controller.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.controller.js b/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.controller.js index a29ce86..84272cb 100644 --- a/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.controller.js +++ b/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.controller.js @@ -42,7 +42,7 @@ export default [ $scope.tabsServer = { activeTab: 0 }; $scope.tabsClient = { activeTab: 0 }; - $scope.selectItem = cluster => { + $scope.selectItem = (cluster) => { delete ctrl.cluster; if (!cluster) @@ -56,7 +56,7 @@ export default [ sessionStorage.summarySelectedId = $scope.clusters.indexOf(cluster); }; - const updateTab = cluster => { + const updateTab = (cluster) => { if (!cluster) return; http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.resource.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.resource.js b/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.resource.js index 14721b8..aee20cc 100644 --- a/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.resource.js +++ b/modules/control-center-web/src/main/js/app/modules/states/configuration/summary/summary.resource.js @@ -27,13 +27,13 @@ export default ['ConfigurationSummaryResource', ['$q', '$http', ($q, $http) => { if (!clusters || !clusters.length) return {}; - _.each(clusters, cluster => { + _.each(clusters, (cluster) => { cluster.igfss = _.filter(igfss, ({_id}) => _.contains(cluster.igfss, _id)); cluster.caches = _.filter(caches, ({_id}) => _.contains(cluster.caches, _id)); }); return {clusters}; - }, err => { + }, (err) => { return $q.reject(err); }); } http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/app/services/UiAceOnLoad/service.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/app/services/UiAceOnLoad/service.js b/modules/control-center-web/src/main/js/app/services/UiAceOnLoad/service.js index 3c87b94..84389a3 100644 --- a/modules/control-center-web/src/main/js/app/services/UiAceOnLoad/service.js +++ b/modules/control-center-web/src/main/js/app/services/UiAceOnLoad/service.js @@ -16,7 +16,7 @@ */ export default ['IgniteUiAceOnLoad', () => { - return editor => { + return (editor) => { editor.setReadOnly(true); editor.setOption('highlightActiveLine', false); editor.setAutoScrollEditorIntoView(true); http://git-wip-us.apache.org/repos/asf/ignite/blob/8d0f2b04/modules/control-center-web/src/main/js/gulpfile.js/tasks/eslint.js ---------------------------------------------------------------------- diff --git a/modules/control-center-web/src/main/js/gulpfile.js/tasks/eslint.js b/modules/control-center-web/src/main/js/gulpfile.js/tasks/eslint.js index e1db55f..696144f 100644 --- a/modules/control-center-web/src/main/js/gulpfile.js/tasks/eslint.js +++ b/modules/control-center-web/src/main/js/gulpfile.js/tasks/eslint.js @@ -26,4 +26,4 @@ gulp.task('eslint', function() { return gulp.src(paths) .pipe(eslint()) .pipe(eslint.format()); -}) \ No newline at end of file +});