This is an automated email from the ASF dual-hosted git repository. mmuzaf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push: new 54b7b40 IGNITE-12949: Add support for NoWhitespaceAfter to the checkstyle (#7731) 54b7b40 is described below commit 54b7b403e44bd61065c8c1906f7b9861bd5e78d2 Author: Nikita Amelchev <nsamelc...@gmail.com> AuthorDate: Sun Apr 26 23:22:08 2020 +0300 IGNITE-12949: Add support for NoWhitespaceAfter to the checkstyle (#7731) --- checkstyle/checkstyle.xml | 9 +++++++++ .../org/apache/ignite/p2p/P2PGridifySelfTest.java | 2 +- .../misc/JmhPartitionUpdateCounterBenchmark.java | 2 +- .../jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java | 4 ++-- .../JdbcThinConnectionMultipleAddressesTest.java | 2 +- .../jdbc/thin/JdbcThinConnectionSelfTest.java | 22 +++++++++++----------- .../jdbc/thin/JdbcThinInsertStatementSelfTest.java | 2 +- .../apache/ignite/IgniteJdbcThinDataSource.java | 2 +- .../rendezvous/RendezvousAffinityFunction.java | 4 ++-- .../ignite/internal/ThinProtocolFeature.java | 2 +- .../jdbc/thin/ConnectionPropertiesImpl.java | 14 +++++++------- .../bulkload/pipeline/CharsetDecoderBlock.java | 2 +- .../processors/igfs/IgfsOutputStreamProxyImpl.java | 2 +- .../odbc/jdbc/JdbcBatchExecuteResult.java | 4 ++-- .../platform/client/ClientConnectionContext.java | 2 +- .../ignite/internal/sql/SqlParseException.java | 2 +- .../optimized/OptimizedMarshallerTest.java | 2 +- .../CachePartitionLossDetectionOnNodeLeftTest.java | 3 ++- .../query/GridCacheQueryTransformerSelfTest.java | 2 +- ...rtitionCounterStateOnePrimaryOneBackupTest.java | 2 +- ...titionCounterStateTwoPrimaryTwoBackupsTest.java | 2 +- .../TxPessimisticDeadlockDetectionTest.java | 2 +- .../GridUnsafeDataOutputArraySizingSelfTest.java | 2 +- .../ignite/loadtests/job/GridJobLoadTestJob.java | 2 +- .../java/org/apache/ignite/p2p/GridP2PTestJob.java | 2 +- .../FilterDataForClientNodeDiscoveryTest.java | 2 +- .../IgniteHadoopFileSystemClientBasedOpenTest.java | 2 +- .../shuffle/streams/HadoopDataStreamSelfTest.java | 4 ++-- .../query/h2/sql/GridSqlAggregateFunction.java | 2 +- .../ignite/ml/optimization/LossFunctions.java | 2 +- .../util/SimpleStepFunctionCompressorTest.java | 2 +- .../uri/GridUriDeploymentMd5CheckSelfTest.java | 2 +- 32 files changed, 61 insertions(+), 51 deletions(-) diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml index a14b4c2..24bf995 100644 --- a/checkstyle/checkstyle.xml +++ b/checkstyle/checkstyle.xml @@ -75,5 +75,14 @@ See: https://checkstyle.sourceforge.io/config_whitespace.html#MethodParamPad --> <module name="MethodParamPad"/> + + <!-- + Checks that there is no whitespace after a token. + See: https://checkstyle.sourceforge.io/config_whitespace.html#NoWhitespaceAfter + --> + <module name="NoWhitespaceAfter"> + <property name="tokens" value="AT, INC, DEC, UNARY_MINUS, UNARY_PLUS, BNOT, LNOT, DOT, ARRAY_DECLARATOR, + INDEX_OP, METHOD_REF"/> + </module> </module> </module> diff --git a/modules/aop/src/test/java/org/apache/ignite/p2p/P2PGridifySelfTest.java b/modules/aop/src/test/java/org/apache/ignite/p2p/P2PGridifySelfTest.java index 7a58010..85479ae 100644 --- a/modules/aop/src/test/java/org/apache/ignite/p2p/P2PGridifySelfTest.java +++ b/modules/aop/src/test/java/org/apache/ignite/p2p/P2PGridifySelfTest.java @@ -140,7 +140,7 @@ public class P2PGridifySelfTest extends GridCommonAbstractTest { ); // Test property file load. - byte [] bytes = new byte[20]; + byte[] bytes = new byte[20]; try (InputStream in = tstClsLdr.getResourceAsStream(path)) { if (in == null) { diff --git a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/misc/JmhPartitionUpdateCounterBenchmark.java b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/misc/JmhPartitionUpdateCounterBenchmark.java index e1bd9b0..ff45c9f 100644 --- a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/misc/JmhPartitionUpdateCounterBenchmark.java +++ b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/misc/JmhPartitionUpdateCounterBenchmark.java @@ -55,7 +55,7 @@ public class JmhPartitionUpdateCounterBenchmark { private static final int COUNTER_MAX_DELTA = 50; /** Testing gaps buffer. */ - private final long [][] gapsBuf = new long[GAPS_BUFFER_SIZE][]; + private final long[][] gapsBuf = new long[GAPS_BUFFER_SIZE][]; /** Random numbers generator. */ private Random rnd; diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java index 372fd35..099118f 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinComplexDmlDdlSelfTest.java @@ -328,7 +328,7 @@ public class JdbcThinComplexDmlDdlSelfTest extends GridCommonAbstractTest { int cols = rs.getMetaData().getColumnCount(); while (rs.next()) { - Object [] rowObjs = new Object[cols]; + Object[] rowObjs = new Object[cols]; for (int i = 0; i < cols; ++i) rowObjs[i] = rs.getObject(i + 1); @@ -414,7 +414,7 @@ public class JdbcThinComplexDmlDdlSelfTest extends GridCommonAbstractTest { int cols = rs.getMetaData().getColumnCount(); while (rs.next()) { - Object [] rowObjs = new Object[cols]; + Object[] rowObjs = new Object[cols]; for (int i = 0; i < cols; ++i) rowObjs[i] = rs.getObject(i + 1); diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionMultipleAddressesTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionMultipleAddressesTest.java index afd07e9..19a7570 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionMultipleAddressesTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionMultipleAddressesTest.java @@ -469,7 +469,7 @@ public class JdbcThinConnectionMultipleAddressesTest extends JdbcThinAbstractSel stop(conn, allNodes); - final int [] id = {0}; + final int[] id = {0}; GridTestUtils.assertThrows(log, new Callable<Object>() { @Override public Object call() throws Exception { diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java index 7eaf0ec..04c2097 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java @@ -789,10 +789,10 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { @Test public void testCreateStatement2() throws Exception { try (Connection conn = DriverManager.getConnection(urlWithPartitionAwarenessProp)) { - int [] rsTypes = new int[] + int[] rsTypes = new int[] {TYPE_FORWARD_ONLY, ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.TYPE_SCROLL_SENSITIVE}; - int [] rsConcurs = new int[] + int[] rsConcurs = new int[] {CONCUR_READ_ONLY, ResultSet.CONCUR_UPDATABLE}; DatabaseMetaData meta = conn.getMetaData(); @@ -843,13 +843,13 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { @Test public void testCreateStatement3() throws Exception { try (Connection conn = DriverManager.getConnection(urlWithPartitionAwarenessProp)) { - int [] rsTypes = new int[] + int[] rsTypes = new int[] {TYPE_FORWARD_ONLY, ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.TYPE_SCROLL_SENSITIVE}; - int [] rsConcurs = new int[] + int[] rsConcurs = new int[] {CONCUR_READ_ONLY, ResultSet.CONCUR_UPDATABLE}; - int [] rsHoldabilities = new int[] + int[] rsHoldabilities = new int[] {HOLD_CURSORS_OVER_COMMIT, CLOSE_CURSORS_AT_COMMIT}; DatabaseMetaData meta = conn.getMetaData(); @@ -939,10 +939,10 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { try (Connection conn = DriverManager.getConnection(urlWithPartitionAwarenessProp)) { final String sqlText = "select * from test where param = ?"; - int [] rsTypes = new int[] + int[] rsTypes = new int[] {TYPE_FORWARD_ONLY, ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.TYPE_SCROLL_SENSITIVE}; - int [] rsConcurs = new int[] + int[] rsConcurs = new int[] {CONCUR_READ_ONLY, ResultSet.CONCUR_UPDATABLE}; DatabaseMetaData meta = conn.getMetaData(); @@ -1000,13 +1000,13 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { try (Connection conn = DriverManager.getConnection(urlWithPartitionAwarenessProp)) { final String sqlText = "select * from test where param = ?"; - int [] rsTypes = new int[] + int[] rsTypes = new int[] {TYPE_FORWARD_ONLY, ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.TYPE_SCROLL_SENSITIVE}; - int [] rsConcurs = new int[] + int[] rsConcurs = new int[] {CONCUR_READ_ONLY, ResultSet.CONCUR_UPDATABLE}; - int [] rsHoldabilities = new int[] + int[] rsHoldabilities = new int[] {HOLD_CURSORS_OVER_COMMIT, CLOSE_CURSORS_AT_COMMIT}; DatabaseMetaData meta = conn.getMetaData(); @@ -2215,7 +2215,7 @@ public class JdbcThinConnectionSelfTest extends JdbcThinAbstractSelfTest { final boolean end[] = new boolean[] {false}; - final SQLException exs [] = new SQLException[threadCnt]; + final SQLException exs[] = new SQLException[threadCnt]; final AtomicInteger exCnt = new AtomicInteger(0); diff --git a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinInsertStatementSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinInsertStatementSelfTest.java index 6a71ce6..5bdff4d 100644 --- a/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinInsertStatementSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinInsertStatementSelfTest.java @@ -42,7 +42,7 @@ public class JdbcThinInsertStatementSelfTest extends JdbcThinAbstractDmlStatemen "(?, ?, ?, ?, ?), (?, ?, ?, ?, ?), (?, ?, ?, ?, ?)"; /** Arguments for prepared statement. */ - private final Object [][] args = new Object[][] { + private final Object[][] args = new Object[][] { {"p1", 1, "John", "White", 25}, {"p3", 3, "Mike", "Green", 40}, {"p2", 2, "Joe", "Black", 35} diff --git a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java index 05dfb3c..a3b84cb 100644 --- a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java +++ b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java @@ -126,7 +126,7 @@ public class IgniteJdbcThinDataSource implements DataSource, Serializable { if (addrs == null) return null; - String [] addrsStr = new String[addrs.length]; + String[] addrsStr = new String[addrs.length]; for (int i = 0; i < addrs.length; ++i) addrsStr[i] = addrs[i].toString(); diff --git a/modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/RendezvousAffinityFunction.java b/modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/RendezvousAffinityFunction.java index 9c0e0015..d5ace1d 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/RendezvousAffinityFunction.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/affinity/rendezvous/RendezvousAffinityFunction.java @@ -347,8 +347,8 @@ public class RendezvousAffinityFunction implements AffinityFunction, Serializabl if (nodes.size() <= 1) return nodes; - IgniteBiTuple<Long, ClusterNode> [] hashArr = - (IgniteBiTuple<Long, ClusterNode> [])new IgniteBiTuple[nodes.size()]; + IgniteBiTuple<Long, ClusterNode>[] hashArr = + (IgniteBiTuple<Long, ClusterNode>[])new IgniteBiTuple[nodes.size()]; for (int i = 0; i < nodes.size(); i++) { ClusterNode node = nodes.get(i); diff --git a/modules/core/src/main/java/org/apache/ignite/internal/ThinProtocolFeature.java b/modules/core/src/main/java/org/apache/ignite/internal/ThinProtocolFeature.java index e281d53..3454e65 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/ThinProtocolFeature.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/ThinProtocolFeature.java @@ -54,7 +54,7 @@ public interface ThinProtocolFeature { * @param in Byte array representing all supported features. * @param enumCls Type of the enum encoded by the bits at the byte array. */ - public static <E extends Enum<E> & ThinProtocolFeature> EnumSet<E> enumSet(byte [] in, Class<E> enumCls) { + public static <E extends Enum<E> & ThinProtocolFeature> EnumSet<E> enumSet(byte[] in, Class<E> enumCls) { EnumSet<E> set = EnumSet.noneOf(enumCls); if (in == null) diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/ConnectionPropertiesImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/ConnectionPropertiesImpl.java index 2b73a97..ff23745 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/ConnectionPropertiesImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/ConnectionPropertiesImpl.java @@ -51,7 +51,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa private String url; /** Addresses. */ - private HostAndPortRange [] addrs; + private HostAndPortRange[] addrs; /** Schema name. Hidden property. Is used to set default schema name part of the URL. */ private StringProperty schema = new StringProperty(PROP_SCHEMA, @@ -234,7 +234,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa 0, false, 0, Integer.MAX_VALUE); /** Properties array. */ - private final ConnectionProperty [] propsArray = { + private final ConnectionProperty[] propsArray = { distributedJoins, enforceJoinOrder, collocated, replicatedOnly, autoCloseServerCursor, tcpNoDelay, lazy, socketSendBuffer, socketReceiveBuffer, skipReducerOnUpdate, nestedTxMode, sslMode, sslCipherSuites, sslProtocol, sslKeyAlgorithm, @@ -272,7 +272,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa StringBuilder sbUrl = new StringBuilder(JdbcThinUtils.URL_PREFIX); - HostAndPortRange [] addrs = getAddresses(); + HostAndPortRange[] addrs = getAddresses(); for (int i = 0; i < addrs.length; i++) { if (i > 0) @@ -780,7 +780,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa * @throws SQLException If failed. */ private void parseEndpoints(String endpointStr) throws SQLException { - String [] endpoints = endpointStr.split(","); + String[] endpoints = endpointStr.split(","); if (endpoints.length > 0) addrs = new HostAndPortRange[endpoints.length]; @@ -922,7 +922,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa * An array of possible values if the value may be selected * from a particular set of values; otherwise null. */ - protected String [] choices; + protected String[] choices; /** Required flag. */ protected boolean required; @@ -1059,7 +1059,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa private static final long serialVersionUID = 0L; /** Bool choices. */ - private static final String [] boolChoices = new String[] {Boolean.TRUE.toString(), Boolean.FALSE.toString()}; + private static final String[] boolChoices = new String[] {Boolean.TRUE.toString(), Boolean.FALSE.toString()}; /** Value. */ private Boolean val; @@ -1125,7 +1125,7 @@ public class ConnectionPropertiesImpl implements ConnectionProperties, Serializa protected Number val; /** Allowed value range. */ - private Number [] range; + private Number[] range; /** * @param name Name. diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/bulkload/pipeline/CharsetDecoderBlock.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/bulkload/pipeline/CharsetDecoderBlock.java index f9031b1..8dc6a5f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/bulkload/pipeline/CharsetDecoderBlock.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/bulkload/pipeline/CharsetDecoderBlock.java @@ -127,7 +127,7 @@ public class CharsetDecoderBlock extends PipelineBlock<byte[], char[]> { continue; } - assert ! res.isMalformed() && ! res.isUnmappable(); + assert !res.isMalformed() && !res.isUnmappable(); // We're not supposed to reach this point with the current implementation. // The code below will fire exception if Oracle implementation of CharsetDecoder will be changed in future. diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsOutputStreamProxyImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsOutputStreamProxyImpl.java index fc318ef..7448797 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsOutputStreamProxyImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/igfs/IgfsOutputStreamProxyImpl.java @@ -126,7 +126,7 @@ class IgfsOutputStreamProxyImpl extends IgfsAbstractOutputStream { // Increment metrics. bytes += writeLen; - byte [] dataBuf = new byte[writeLen]; + byte[] dataBuf = new byte[writeLen]; if (data instanceof ByteBuffer) { ByteBuffer byteBuf = (ByteBuffer)data; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcBatchExecuteResult.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcBatchExecuteResult.java index b40674a..5effd2d 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcBatchExecuteResult.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcBatchExecuteResult.java @@ -28,7 +28,7 @@ import org.apache.ignite.internal.util.typedef.internal.S; */ public class JdbcBatchExecuteResult extends JdbcResult { /** Update counts. */ - private int [] updateCnts; + private int[] updateCnts; /** Batch update error code. */ private int errCode; @@ -56,7 +56,7 @@ public class JdbcBatchExecuteResult extends JdbcResult { * @param errCode Error code. * @param errMsg Error message. */ - JdbcBatchExecuteResult(int [] updateCnts, int errCode, String errMsg) { + JdbcBatchExecuteResult(int[] updateCnts, int errCode, String errMsg) { super(BATCH_EXEC); this.updateCnts = updateCnts; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientConnectionContext.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientConnectionContext.java index a981430..3a1dbb5 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientConnectionContext.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientConnectionContext.java @@ -176,7 +176,7 @@ public class ClientConnectionContext extends ClientListenerAbstractConnectionCon EnumSet<ClientBitmaskFeature> features = null; if (ClientProtocolContext.isFeatureSupported(ver, BITMAP_FEATURES)) { - byte [] cliFeatures = reader.readByteArray(); + byte[] cliFeatures = reader.readByteArray(); features = ClientBitmaskFeature.enumSet(cliFeatures); } diff --git a/modules/core/src/main/java/org/apache/ignite/internal/sql/SqlParseException.java b/modules/core/src/main/java/org/apache/ignite/internal/sql/SqlParseException.java index c31824c..3b3fa37 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/sql/SqlParseException.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/sql/SqlParseException.java @@ -62,7 +62,7 @@ public class SqlParseException extends IgniteException { sql = e.sql; pos = e.pos; - code = e. code; + code = e.code; } /** diff --git a/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerTest.java b/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerTest.java index 2edb190..f283eb7 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerTest.java @@ -221,7 +221,7 @@ public class OptimizedMarshallerTest extends GridCommonAbstractTest { SomeSimpleSerializable outObj = marsh.unmarshal(marsh.marshal(newObj), null); - assert (! outObj.flag); + assert !outObj.flag; } /** diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CachePartitionLossDetectionOnNodeLeftTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CachePartitionLossDetectionOnNodeLeftTest.java index 34f4e64..88792ec 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CachePartitionLossDetectionOnNodeLeftTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CachePartitionLossDetectionOnNodeLeftTest.java @@ -48,7 +48,8 @@ public class CachePartitionLossDetectionOnNodeLeftTest extends GridCommonAbstrac cfg.setCacheConfiguration(new CacheConfiguration(DEFAULT_CACHE_NAME). setAtomicityMode(TRANSACTIONAL). setCacheMode(PARTITIONED). - setPartitionLossPolicy(IGNORE). // If default will ever change... + // If default will ever change... + setPartitionLossPolicy(IGNORE). setBackups(0)); cfg.setIncludeEventTypes(EventType.EVTS_ALL); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryTransformerSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryTransformerSelfTest.java index 07261e1..6920663 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryTransformerSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryTransformerSelfTest.java @@ -174,7 +174,7 @@ public class GridCacheQueryTransformerSelfTest extends GridCommonAbstractTest { Affinity<Integer> affinity = affinity(cache); try { - int [] keys = new int[50]; + int[] keys = new int[50]; for (int i = 0, j = 0; i < keys.length; j++) { if (affinity.partition(j) == 0) diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateOnePrimaryOneBackupTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateOnePrimaryOneBackupTest.java index d2bb8a1..cab7786 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateOnePrimaryOneBackupTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateOnePrimaryOneBackupTest.java @@ -52,7 +52,7 @@ public class TxPartitionCounterStateOnePrimaryOneBackupTest extends TxPartitionC private static final int[] BACKUP_COMMIT_ORDER = new int[] {1, 2, 0}; /** */ - private static final int [] SIZES = new int[] {5, 7, 3}; + private static final int[] SIZES = new int[] {5, 7, 3}; /** */ private static final int TOTAL = IntStream.of(SIZES).sum() + PRELOAD_KEYS_CNT; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateTwoPrimaryTwoBackupsTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateTwoPrimaryTwoBackupsTest.java index b1652ab..c097099 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateTwoPrimaryTwoBackupsTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateTwoPrimaryTwoBackupsTest.java @@ -47,7 +47,7 @@ import org.junit.Test; */ public class TxPartitionCounterStateTwoPrimaryTwoBackupsTest extends TxPartitionCounterStateAbstractTest { /** Tx sizes. */ - private static final int [] SIZES = new int[] {5, 7, 3}; + private static final int[] SIZES = new int[] {5, 7, 3}; /** */ private static final int TOTAL = IntStream.of(SIZES).sum() + PRELOAD_KEYS_CNT; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPessimisticDeadlockDetectionTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPessimisticDeadlockDetectionTest.java index 8b9d65a..176210c 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPessimisticDeadlockDetectionTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPessimisticDeadlockDetectionTest.java @@ -308,7 +308,7 @@ public class TxPessimisticDeadlockDetectionTest extends AbstractDeadlockDetectio entries.put(o, 1); - k = incrementKey(o, + 13); + k = incrementKey(o, +13); involvedKeys.add(k); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/util/io/GridUnsafeDataOutputArraySizingSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/util/io/GridUnsafeDataOutputArraySizingSelfTest.java index d626a9c..6686187 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/util/io/GridUnsafeDataOutputArraySizingSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/util/io/GridUnsafeDataOutputArraySizingSelfTest.java @@ -119,7 +119,7 @@ public class GridUnsafeDataOutputArraySizingSelfTest extends GridCommonAbstractT final GridUnsafeDataOutput out; /** */ - final byte [] bytes; + final byte[] bytes; /** */ final int len; diff --git a/modules/core/src/test/java/org/apache/ignite/loadtests/job/GridJobLoadTestJob.java b/modules/core/src/test/java/org/apache/ignite/loadtests/job/GridJobLoadTestJob.java index 9b8118e..c893050 100644 --- a/modules/core/src/test/java/org/apache/ignite/loadtests/job/GridJobLoadTestJob.java +++ b/modules/core/src/test/java/org/apache/ignite/loadtests/job/GridJobLoadTestJob.java @@ -147,7 +147,7 @@ public class GridJobLoadTestJob implements ComputeJob { Integer val = (Integer) attrs.get(String.valueOf(i)); // We shouldn't run in situation when some elements emitted before are missed and the current exists. - assert ! (valMissed && val != null) : + assert !(valMissed && val != null) : "Inconsistent session attribute set was received [missedAttribute=" + i + ", jobId=" + cntx.getJobId() + ", attrs=" + attrs + ", nodeId=" + ignite.configuration().getNodeId() + "]"; diff --git a/modules/core/src/test/java/org/apache/ignite/p2p/GridP2PTestJob.java b/modules/core/src/test/java/org/apache/ignite/p2p/GridP2PTestJob.java index 71b5eb42..d68265d 100644 --- a/modules/core/src/test/java/org/apache/ignite/p2p/GridP2PTestJob.java +++ b/modules/core/src/test/java/org/apache/ignite/p2p/GridP2PTestJob.java @@ -81,7 +81,7 @@ public class GridP2PTestJob extends ComputeJobAdapter { } // Test property file load. - byte [] bytes = new byte[20]; + byte[] bytes = new byte[20]; try { in.read(bytes); diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/FilterDataForClientNodeDiscoveryTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/FilterDataForClientNodeDiscoveryTest.java index 3424d4e..9996791 100644 --- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/FilterDataForClientNodeDiscoveryTest.java +++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/FilterDataForClientNodeDiscoveryTest.java @@ -77,7 +77,7 @@ public class FilterDataForClientNodeDiscoveryTest extends GridCommonAbstractTest startClientGrid(configuration(2)); startClientGrid(configuration(3)); - final boolean [] recvMsg = new boolean[4]; + final boolean[] recvMsg = new boolean[4]; for (int i = 0; i < 4; ++i) { final int idx0 = i; diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientBasedOpenTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientBasedOpenTest.java index ef382c7..b34a03a 100644 --- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientBasedOpenTest.java +++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientBasedOpenTest.java @@ -39,7 +39,7 @@ import org.junit.Test; */ public class IgniteHadoopFileSystemClientBasedOpenTest extends GridCommonAbstractTest { /** Config root path. */ - private static final String [] CONFIGS = { + private static final String[] CONFIGS = { "modules/hadoop/src/test/config/hadoop-fs-open-test/grid-0.xml", "modules/hadoop/src/test/config/hadoop-fs-open-test/grid-1.xml", "modules/hadoop/src/test/config/hadoop-fs-open-test/grid-2.xml" diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/shuffle/streams/HadoopDataStreamSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/shuffle/streams/HadoopDataStreamSelfTest.java index cb4880a..cb72e8f 100644 --- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/shuffle/streams/HadoopDataStreamSelfTest.java +++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/shuffle/streams/HadoopDataStreamSelfTest.java @@ -73,7 +73,7 @@ public class HadoopDataStreamSelfTest extends GridCommonAbstractTest { write(out); - byte [] inBuf = Arrays.copyOf(out.buffer(), out.position()); + byte[] inBuf = Arrays.copyOf(out.buffer(), out.position()); HadoopDirectDataInput in = new HadoopDirectDataInput(inBuf); @@ -162,7 +162,7 @@ public class HadoopDataStreamSelfTest extends GridCommonAbstractTest { out.write(val.getBytes()); - byte [] inBuf = Arrays.copyOf(out.buffer(), out.position()); + byte[] inBuf = Arrays.copyOf(out.buffer(), out.position()); HadoopDirectDataInput in = new HadoopDirectDataInput(inBuf); diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlAggregateFunction.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlAggregateFunction.java index e30da90..b02b8c9 100644 --- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlAggregateFunction.java +++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlAggregateFunction.java @@ -136,7 +136,7 @@ public class GridSqlAggregateFunction extends GridSqlFunction { * @return {@code true} in case GROUP_CONCAT function contains ORDER BY expressions. */ public boolean hasGroupConcatOrder() { - return ! F.isEmpty(groupConcatOrderExpression); + return !F.isEmpty(groupConcatOrderExpression); } /** diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/optimization/LossFunctions.java b/modules/ml/src/main/java/org/apache/ignite/ml/optimization/LossFunctions.java index 59a7fc9..bd467c0 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/optimization/LossFunctions.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/optimization/LossFunctions.java @@ -59,7 +59,7 @@ public class LossFunctions { /** {@inheritDoc} */ @Override public Double apply(Vector vector) { return groundTruth.copy().map(vector, - (a, b) -> a == 1 ? - Math.log(b) : -Math.log(1 - b) + (a, b) -> a == 1 ? -Math.log(b) : -Math.log(1 - b) ).sum(); } }; diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/tree/impurity/util/SimpleStepFunctionCompressorTest.java b/modules/ml/src/test/java/org/apache/ignite/ml/tree/impurity/util/SimpleStepFunctionCompressorTest.java index 579d592..cca8a9b 100644 --- a/modules/ml/src/test/java/org/apache/ignite/ml/tree/impurity/util/SimpleStepFunctionCompressorTest.java +++ b/modules/ml/src/test/java/org/apache/ignite/ml/tree/impurity/util/SimpleStepFunctionCompressorTest.java @@ -36,7 +36,7 @@ public class SimpleStepFunctionCompressorTest { SimpleStepFunctionCompressor<TestImpurityMeasure> compressor = new SimpleStepFunctionCompressor<>(); - StepFunction<TestImpurityMeasure> resFunction = compressor.compress(new StepFunction [] {function})[0]; + StepFunction<TestImpurityMeasure> resFunction = compressor.compress(new StepFunction[] {function})[0]; assertArrayEquals(new double[]{1, 2, 3, 4}, resFunction.getX(), 1e-10); assertArrayEquals(TestImpurityMeasure.asTestImpurityMeasures(1, 2, 3, 4), resFunction.getY()); diff --git a/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentMd5CheckSelfTest.java b/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentMd5CheckSelfTest.java index 29e5271..5a658e4 100644 --- a/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentMd5CheckSelfTest.java +++ b/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentMd5CheckSelfTest.java @@ -124,7 +124,7 @@ public class GridUriDeploymentMd5CheckSelfTest extends GridUriDeploymentAbstract private File getDeployDir() { File tmpDir = new File(GridTestProperties.getProperty("deploy.uri.file2.path")); - if (! tmpDir.exists()) + if (!tmpDir.exists()) tmpDir.mkdirs(); assert tmpDir.isDirectory();