This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit d164bf42f9fd8ec65db44a5904730587d2b961ec
Author: Qifan Chen <qc...@cloudera.com>
AuthorDate: Tue Oct 27 12:33:52 2020 -0400
IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile
This fix improved the skew reporting test by lowering the threshold
to 0 and by taking care of the extreme case of no skews.
Testing:
1. Unit testing.
Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b
Reviewed-on: http://gerrit.cloudera.org:8080/16662
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
tests/query_test/test_observability.py | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/query_test/test_observability.py
b/tests/query_test/test_observability.py
index f5f1e7e..57d09f1 100644
--- a/tests/query_test/test_observability.py
+++ b/tests/query_test/test_observability.py
@@ -743,22 +743,22 @@ class TestObservability(ImpalaTestSuite):
group by ca_state
order by ca_state
"""
- "Set up the skew threshold to 0.02"
- query_opts = {'report_skew_limit': 0.02}
+ "Set up the skew threshold to 0.0"
+ query_opts = {'report_skew_limit': 0.0}
results = self.execute_query(query, query_opts)
assert results.success
- "Expect to see the skew summary"
+ "When the skew summary is seen, look for the details"
skews_found = 'skew\(s\) found at:.*HASH_JOIN.*HASH_JOIN.*HDFS_SCAN_NODE'
- assert len(re.findall(skews_found, results.runtime_profile, re.M)) == 1
+ if len(re.findall(skews_found, results.runtime_profile, re.M)) == 1:
- "Expect to see skew details twice at the hash join nodes."
- probe_rows_at_hj = 'HASH_JOIN_NODE.*\n.*Skew details: ProbeRows'
- assert len(re.findall(probe_rows_at_hj, results.runtime_profile, re.M)) ==
2
+ "Expect to see skew details twice at the hash join nodes."
+ probe_rows_at_hj = 'HASH_JOIN_NODE.*\n.*Skew details: ProbeRows'
+ assert len(re.findall(probe_rows_at_hj, results.runtime_profile, re.M))
== 2
- "Expect to see skew details once at the scan node."
- probe_rows_at_hdfs_scan = 'HDFS_SCAN_NODE.*\n.*Skew details: RowsRead'
- assert len(re.findall(probe_rows_at_hdfs_scan, results.runtime_profile,
re.M)) == 1
+ "Expect to see skew details once at the scan node."
+ probe_rows_at_hdfs_scan = 'HDFS_SCAN_NODE.*\n.*Skew details: RowsRead'
+ assert len(re.findall(probe_rows_at_hdfs_scan, results.runtime_profile,
re.M)) == 1
class TestQueryStates(ImpalaTestSuite):
"""Test that the 'Query State' and 'Impala Query State' are set correctly in
the
