This is an automated email from the ASF dual-hosted git repository. joemcdonnell pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push: new 56f35ad40 IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default 56f35ad40 is described below commit 56f35ad40a7ded4a700222eef8dc99cf7ea44625 Author: Joe McDonnell <joemcdonn...@cloudera.com> AuthorDate: Mon Jan 8 12:01:53 2024 -0800 IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default IMPALA_COMPRESSED_DEBUG_INFO was introduced in IMPALA-11511 and reduces Impala binary sizes by >50%. Debug tools like gdb and our minidump processing scripts handle compressed debug information properly. There are slightly higher link times and additional overhead when doing debugging. Overall, the reduction in binary sizes seems worth it given the modest overhead. Compressing the debug information also avoids concerns that adding debug information to toolchain components would increase binary sizes. This changes the default for IMPALA_COMPRESSED_DEBUG_INFO to true. Testing: - Ran pstack on a Centos 7 machine running tests with IMPALA_COMPRESSED_DEBUG_INFO=true and verified that the symbols work properly - Forced the production of minidumps for a job using IMPALA_COMPRESSED_DEBUG_INFO=true and verified it is processed properly. - Used this locally for development for several months Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3 Reviewed-on: http://gerrit.cloudera.org:8080/20871 Reviewed-by: Quanlong Huang <huangquanl...@gmail.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- bin/impala-config.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bin/impala-config.sh b/bin/impala-config.sh index 30ceb6d1a..de5737909 100755 --- a/bin/impala-config.sh +++ b/bin/impala-config.sh @@ -569,10 +569,11 @@ export ENABLE_IMPALA_IR_DEBUG_INFO=${ENABLE_IMPALA_IR_DEBUG_INFO-false} # the Breakpad scripts have been modified to handle it, but there may # be other tools that do not know how to use it. This reduces the size # of binaries by 50+%. -# Both of these are disabled by default. -# TODO: Explore enabling IMPALA_COMPRESSED_DEBUG_INFO by default. +# +# Due to the major reduction in binary size and broad support in debugging +# tools, compressed debug information is enabled by default. export IMPALA_MINIMAL_DEBUG_INFO=${IMPALA_MINIMAL_DEBUG_INFO-false} -export IMPALA_COMPRESSED_DEBUG_INFO=${IMPALA_COMPRESSED_DEBUG_INFO-false} +export IMPALA_COMPRESSED_DEBUG_INFO=${IMPALA_COMPRESSED_DEBUG_INFO-true} # Download and use the CDH components from S3. It can be useful to set this to false if # building against a custom local build using HIVE_SRC_DIR_OVERRIDE,