Fix minor perf bug in BufferedTupleStream The code referenced a member variable when the intent was clearly to use the template argument.
Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860 Reviewed-on: http://gerrit.cloudera.org:8080/10239 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/ad33cf55 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/ad33cf55 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/ad33cf55 Branch: refs/heads/2.x Commit: ad33cf55566eae3ca8b305d1c1bf0a9a48165d4c Parents: ae9c47b Author: Tim Armstrong <tarmstr...@cloudera.com> Authored: Mon Apr 30 09:08:11 2018 -0700 Committer: Impala Public Jenkins <impala-public-jenk...@gerrit.cloudera.org> Committed: Thu May 3 19:59:25 2018 +0000 ---------------------------------------------------------------------- be/src/runtime/buffered-tuple-stream.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/ad33cf55/be/src/runtime/buffered-tuple-stream.cc ---------------------------------------------------------------------- diff --git a/be/src/runtime/buffered-tuple-stream.cc b/be/src/runtime/buffered-tuple-stream.cc index f5668c7..9326507 100644 --- a/be/src/runtime/buffered-tuple-stream.cc +++ b/be/src/runtime/buffered-tuple-stream.cc @@ -1038,7 +1038,7 @@ template <bool HAS_NULLABLE_TUPLE> void BufferedTupleStream::UnflattenTupleRow(uint8_t** data, TupleRow* row) const { const int tuples_per_row = desc_->tuple_descriptors().size(); uint8_t* ptr = *data; - if (has_nullable_tuple_) { + if (HAS_NULLABLE_TUPLE) { // Stitch together the tuples from the page and the NULL ones. const uint8_t* null_indicators = ptr; ptr += NullIndicatorBytesPerRow();