This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch ISIS-1846_internal_utils
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/ISIS-1846_internal_utils by
this push:
new 62725eb ISIS-1846 added reviewer notes and questions
62725eb is described below
commit 62725eb3dfd7cf5c995eb5d943781437bd37e274
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Wed Jan 24 09:27:47 2018 +0100
ISIS-1846 added reviewer notes and questions
---
.../isis/applib/internal/reflection/_Reflect.java | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git
a/core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect.java
b/core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect.java
index fcffa73..589cf31 100644
---
a/core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect.java
+++
b/core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect.java
@@ -44,23 +44,34 @@ public final class _Reflect {
// -- REFLECTIVE CLASS DISCOVERY
+ /**
+ * Provides search-methods on class hierarchies.
+ */
public static interface Discovery {
+
+ //TODO missing java-doc
public Set<Class<?>> getTypesAnnotatedWith(Class<? extends
Annotation> annotation);
+
+ //TODO missing java-doc
public <T> Set<Class<? extends T>> getSubTypesOf(Class<T> type);
}
+ //TODO missing java-doc
public static Discovery discover(String packageNamePrefix) {
- _Reflect_Manifest.prepareDiscovery();
+ _Reflect_Manifest.prepareDiscovery(); //TODO [ahuber] REVIEW
why is this required?
return _Reflect_Discovery.of(packageNamePrefix);
}
+ //TODO missing java-doc
public static Discovery discover(List<String> packageNamePrefixes) {
- _Reflect_Manifest.prepareDiscovery();
+ _Reflect_Manifest.prepareDiscovery(); //TODO [ahuber] REVIEW
why is this required?
return _Reflect_Discovery.of(packageNamePrefixes);
}
+ //TODO missing java-doc
+ //TODO [ahuber] REVIEW how is this different from discover(String)
public static Discovery discoverFullscan(String packageNamePrefix) {
- _Reflect_Manifest.prepareDiscovery();
+ _Reflect_Manifest.prepareDiscovery(); //TODO [ahuber] REVIEW
why is this required?
return _Reflect_Discovery.of(
ClasspathHelper.forClassLoader(_Context.getDefaultClassLoader()),
ClasspathHelper.forClass(Object.class),
--
To stop receiving notification emails like this one, please contact
ahu...@apache.org.
