This is an automated email from the ASF dual-hosted git repository.
guozhang pushed a commit to branch 2.4
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.4 by this push:
new f965e79 KAFKA-9029: Flaky Test
CooperativeStickyAssignorTest.testReassignmentWithRand: bump to 4 (#7503)
f965e79 is described below
commit f965e79d49b85591a3d5bd7b6d3562b9278da05e
Author: A. Sophie Blee-Goldman <sop...@confluent.io>
AuthorDate: Sat Oct 12 11:07:12 2019 -0700
KAFKA-9029: Flaky Test
CooperativeStickyAssignorTest.testReassignmentWithRand: bump to 4 (#7503)
One of the sticky assignor tests involves a random change in subscriptions
that the current assignor algorithm struggles to react to and in cooperative
mode ends up requiring more than one followup rebalance.
Apparently, in rare cases it can also require more than 2. Bumping the
"allowed subsequent rebalances" to 4 (increase of 2) to allow some breathing
room and reduce flakiness (technically any number is "correct", but if it turns
out to ever require more than 4 we should revisit and improve the algorithm
because that would be excessive (see KAFKA-8767)
Reviewers: Guozhang Wang <wangg...@gmail.com>
---
.../apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java
b/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java
index 72a6d89..aed8c09 100644
---
a/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java
+++
b/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java
@@ -68,7 +68,7 @@ public class CooperativeStickyAssignorTest extends
AbstractStickyAssignorTest {
assignments.putAll(assignor.assign(partitionsPerTopic,
subscriptions));
++rebalances;
- assertTrue(rebalances <= 2);
+ assertTrue(rebalances <= 4);
}
// Check the validity and balance of the final assignment
