This is an automated email from the ASF dual-hosted git repository.
cmccabe pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3581429 KAFKA-8488: Reduce logging-related string allocation in
FetchSessionHandler
3581429 is described below
commit 35814298e1fa2840f89ef1f40163b2480da28a2b
Author: wenhoujx <wenho...@gmail.com>
AuthorDate: Fri Jun 14 12:24:27 2019 -0400
KAFKA-8488: Reduce logging-related string allocation in FetchSessionHandler
Reviewers: Colin P. McCabe <cmcc...@apache.org>, Ismael Juma
<ism...@juma.me.uk>
---
.../org/apache/kafka/clients/FetchSessionHandler.java | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
a/clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
b/clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
index 30ae65f..5b402bf 100644
--- a/clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
+++ b/clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
@@ -196,8 +196,10 @@ public class FetchSessionHandler {
public FetchRequestData build() {
if (nextMetadata.isFull()) {
- log.debug("Built full fetch {} for node {} with {}.",
- nextMetadata, node, partitionsToLogString(next.keySet()));
+ if (log.isDebugEnabled()) {
+ log.debug("Built full fetch {} for node {} with {}.",
+ nextMetadata, node,
partitionsToLogString(next.keySet()));
+ }
sessionPartitions = next;
next = null;
Map<TopicPartition, PartitionData> toSend =
@@ -247,10 +249,12 @@ public class FetchSessionHandler {
sessionPartitions.put(topicPartition, nextData);
added.add(topicPartition);
}
- log.debug("Built incremental fetch {} for node {}. Added {},
altered {}, removed {} " +
- "out of {}", nextMetadata, node,
partitionsToLogString(added),
- partitionsToLogString(altered),
partitionsToLogString(removed),
- partitionsToLogString(sessionPartitions.keySet()));
+ if (log.isDebugEnabled()) {
+ log.debug("Built incremental fetch {} for node {}. Added {},
altered {}, removed {} " +
+ "out of {}", nextMetadata, node,
partitionsToLogString(added),
+ partitionsToLogString(altered),
partitionsToLogString(removed),
+ partitionsToLogString(sessionPartitions.keySet()));
+ }
Map<TopicPartition, PartitionData> toSend =
Collections.unmodifiableMap(new LinkedHashMap<>(next));
Map<TopicPartition, PartitionData> curSessionPartitions =
