This is an automated email from the ASF dual-hosted git repository. guozhang pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push: new 18b84d0404 MINOR: Fix typos in configuration docs (#11874) 18b84d0404 is described below commit 18b84d0404d891263420628e12a2ce4f2ac85806 Author: Joel Hamill <11722533+joel-ham...@users.noreply.github.com> AuthorDate: Wed May 4 10:27:14 2022 -0700 MINOR: Fix typos in configuration docs (#11874) Reviewers: Chris Egerton, Weikang Sun, Andrew Eugene Choi, Luke Chen, Guozhang Wang --- .../java/org/apache/kafka/clients/producer/ProducerConfig.java | 9 +++++---- .../src/main/java/org/apache/kafka/streams/StreamsConfig.java | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java index 6c258933af..2d586f255c 100644 --- a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java +++ b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java @@ -216,10 +216,11 @@ public class ProducerConfig extends AbstractConfig { /** <code>max.in.flight.requests.per.connection</code> */ public static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION = "max.in.flight.requests.per.connection"; private static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_DOC = "The maximum number of unacknowledged requests the client will send on a single connection before blocking." - + " Note that if this config is set to be greater than 1 and <code>enable.idempotence</code> is set to false, there is a risk of" - + " message re-ordering after a failed send due to retries (i.e., if retries are enabled)." - + " Additionally, enabling idempotence requires this config value to be less than or equal to " + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_FOR_IDEMPOTENCE + "." - + " If conflicting configurations are set and idempotence is not explicitly enabled, idempotence is disabled."; + + " Note that if this configuration is set to be greater than 1 and <code>enable.idempotence</code> is set to false, there is a risk of" + + " message reordering after a failed send due to retries (i.e., if retries are enabled); " + + " if retries are disabled or if <code>enable.idempotence</code> is set to true, ordering will be preserved." + + " Additionally, enabling idempotence requires the value of this configuration to be less than or equal to " + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_FOR_IDEMPOTENCE + "." + + " If conflicting configurations are set and idempotence is not explicitly enabled, idempotence is disabled. "; /** <code>retries</code> */ public static final String RETRIES_CONFIG = CommonClientConfigs.RETRIES_CONFIG; diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java index 23c021c63f..6428f69188 100644 --- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java +++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java @@ -498,8 +498,8 @@ public class StreamsConfig extends AbstractConfig { "<code>org.apache.kafka.common.serialization.Serde</code> interface."; public static final String WINDOWED_INNER_CLASS_SERDE = "windowed.inner.class.serde"; - private static final String WINDOWED_INNER_CLASS_SERDE_DOC = " Default serializer / deserializer for the inner class of a windowed record. Must implement the \" +\n" + - " \"<code>org.apache.kafka.common.serialization.Serde</code> interface.. Note that setting this config in KafkaStreams application would result " + + private static final String WINDOWED_INNER_CLASS_SERDE_DOC = " Default serializer / deserializer for the inner class of a windowed record. Must implement the " + + "<code>org.apache.kafka.common.serialization.Serde</code> interface. Note that setting this config in KafkaStreams application would result " + "in an error as it is meant to be used only from Plain consumer client."; /** {@code default key.serde} */