[PR] [KARAF-7768] Remove org/apache/karaf/specs [karaf]

2024-01-13 Thread via GitHub
rovarga opened a new pull request, #1816: URL: https://github.com/apache/karaf/pull/1816 specs.locator and related logic just dances around the need to integrate with ServiceLoader. In OSGi world that's properly done with adding the appropriate metadata and therefore this magic should not

Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]

2024-01-13 Thread via GitHub
rovarga commented on PR #1784: URL: https://github.com/apache/karaf/pull/1784#issuecomment-1890765848 This PR does the wrong thing, I will raise another one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]

2024-01-13 Thread via GitHub
rovarga closed pull request #1784: [KARAF-7768]: Provide SPI Fly from framework URL: https://github.com/apache/karaf/pull/1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]

2024-01-13 Thread via GitHub
rovarga commented on code in PR #1784: URL: https://github.com/apache/karaf/pull/1784#discussion_r1451604246 ## assemblies/features/framework/src/main/feature/feature.xml: ## @@ -45,6 +45,20 @@