Re: [PR] [KARAF-7325] Support custom properties to simplify adjustment of assemblies [karaf]

2024-04-18 Thread via GitHub
splatch commented on PR #1484: URL: https://github.com/apache/karaf/pull/1484#issuecomment-2064203875 Dang, its quite aged PR, indeed it deserves a push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [KARAF-7325] Support custom properties to simplify adjustment of assemblies [karaf]

2024-04-18 Thread via GitHub
RangerRick commented on PR #1484: URL: https://github.com/apache/karaf/pull/1484#issuecomment-2064121512 Ooh, I realize this is languishing in PRs, but it would be really handy if it could be included. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] allow using `overrides.properties` while generating repositories [karaf]

2024-04-18 Thread via GitHub
RangerRick closed pull request #1821: allow using `overrides.properties` while generating repositories URL: https://github.com/apache/karaf/pull/1821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update Maven plugins and update release plugin configuration [karaf]

2024-04-08 Thread via GitHub
jbonofre merged PR #1844: URL: https://github.com/apache/karaf/pull/1844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update Maven plugins and update release plugin configuration [karaf]

2024-04-08 Thread via GitHub
jbonofre opened a new pull request, #1844: URL: https://github.com/apache/karaf/pull/1844 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7747: Provide Spring 6.1.x/6.0.x features [karaf]

2024-04-07 Thread via GitHub
jbonofre merged PR #1840: URL: https://github.com/apache/karaf/pull/1840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TPRUN-7838 Spring security update for CVE-2024-22257 [karaf]

2024-04-04 Thread via GitHub
andreasmattes closed pull request #1843: TPRUN-7838 Spring security update for CVE-2024-22257 URL: https://github.com/apache/karaf/pull/1843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] TPRUN-7838 Spring security update for CVE-2024-22257 [karaf]

2024-04-04 Thread via GitHub
andreasmattes commented on PR #1843: URL: https://github.com/apache/karaf/pull/1843#issuecomment-2036856553 Erraneous... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KARAF-7817: Upgrade Spring Security features to 5.7.12/5.5.3/5.1.6 [karaf]

2024-04-03 Thread via GitHub
jbonofre merged PR #1829: URL: https://github.com/apache/karaf/pull/1829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7820: Upgrade to Spring 5.3.33 [karaf]

2024-04-03 Thread via GitHub
jbonofre merged PR #1842: URL: https://github.com/apache/karaf/pull/1842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7820: Upgrade to Spring 5.3.33 [karaf]

2024-04-03 Thread via GitHub
jbonofre opened a new pull request, #1842: URL: https://github.com/apache/karaf/pull/1842 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7802: Add javax.annotation.sql and javax.annotation.security packages to etc/jre.properties [karaf]

2024-04-03 Thread via GitHub
jbonofre merged PR #1841: URL: https://github.com/apache/karaf/pull/1841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7802: Add javax.annotation.sql and javax.annotation.security packages to etc/jre.properties [karaf]

2024-04-03 Thread via GitHub
jbonofre opened a new pull request, #1841: URL: https://github.com/apache/karaf/pull/1841 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7747: Provide Spring 6.1.x/6.0.x features [karaf]

2024-04-02 Thread via GitHub
jbonofre opened a new pull request, #1840: URL: https://github.com/apache/karaf/pull/1840 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7813: Upgrade to ASM 9.7 [karaf]

2024-04-01 Thread via GitHub
holgerfriedrich commented on PR #1832: URL: https://github.com/apache/karaf/pull/1832#issuecomment-2029262743 Hi @jbonofre! Thanks for doing all the updates towards 4.4.6 to replace Jetty with a version not affected by CVE-2024-22201. Did you consider to postpone the this update of the

Re: [PR] KARAF-7812: Upgrade to Maven Wagon 3.5.3 [karaf]

2024-03-31 Thread via GitHub
jbonofre merged PR #1835: URL: https://github.com/apache/karaf/pull/1835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7811: Upgrade to commons-compress 1.26.1 [karaf]

2024-03-31 Thread via GitHub
jbonofre merged PR #1836: URL: https://github.com/apache/karaf/pull/1836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7810: Upgrade to commons-logging 1.3.1 [karaf]

2024-03-31 Thread via GitHub
jbonofre merged PR #1837: URL: https://github.com/apache/karaf/pull/1837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7809: Upgrade to bouncycastle 1.77 [karaf]

2024-03-31 Thread via GitHub
jbonofre merged PR #1838: URL: https://github.com/apache/karaf/pull/1838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7801: Upgrade to sshd 2.12.1 [karaf]

2024-03-31 Thread via GitHub
jbonofre merged PR #1839: URL: https://github.com/apache/karaf/pull/1839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7801: Upgrade to sshd 2.12.1 [karaf]

2024-03-30 Thread via GitHub
jbonofre opened a new pull request, #1839: URL: https://github.com/apache/karaf/pull/1839 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7809: Upgrade to bouncycastle 1.77 [karaf]

2024-03-30 Thread via GitHub
jbonofre opened a new pull request, #1838: URL: https://github.com/apache/karaf/pull/1838 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7810: Upgrade to commons-logging 1.3.1 [karaf]

2024-03-30 Thread via GitHub
jbonofre opened a new pull request, #1837: URL: https://github.com/apache/karaf/pull/1837 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7811: Upgrade to commons-compress 1.26.1 [karaf]

2024-03-30 Thread via GitHub
jbonofre opened a new pull request, #1836: URL: https://github.com/apache/karaf/pull/1836 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7814: Upgrade to Pax Web 8.0.27/Jetty 9.4.54.v20240208 [karaf]

2024-03-30 Thread via GitHub
jbonofre merged PR #1833: URL: https://github.com/apache/karaf/pull/1833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7813: Upgrade to ASM 9.7 [karaf]

2024-03-30 Thread via GitHub
jbonofre merged PR #1832: URL: https://github.com/apache/karaf/pull/1832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7815: Upgrade to Pax Logging 2.2.7/slf4j 2.0.12/log4j 2.23.1 [karaf]

2024-03-30 Thread via GitHub
jbonofre merged PR #1831: URL: https://github.com/apache/karaf/pull/1831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7816: Upgrade to Pax JDBC 1.5.7 [karaf]

2024-03-30 Thread via GitHub
jbonofre merged PR #1830: URL: https://github.com/apache/karaf/pull/1830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7819: Upgrade to Spring 5.2.25_1 feature [karaf]

2024-03-30 Thread via GitHub
jbonofre merged PR #1828: URL: https://github.com/apache/karaf/pull/1828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7822: Upgrade to Apache POM 31 [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1834: URL: https://github.com/apache/karaf/pull/1834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7822: Upgrade to Apache POM 31 [karaf]

2024-03-28 Thread via GitHub
jbonofre opened a new pull request, #1834: URL: https://github.com/apache/karaf/pull/1834 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7813: Upgrade to ASM 9.7 [karaf]

2024-03-28 Thread via GitHub
jbonofre opened a new pull request, #1832: URL: https://github.com/apache/karaf/pull/1832 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7814: Upgrade to Pax Web 8.0.27/Jetty 9.4.54.v20240208 [karaf]

2024-03-28 Thread via GitHub
jbonofre opened a new pull request, #1833: URL: https://github.com/apache/karaf/pull/1833 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7816: Upgrade to Pax JDBC 1.5.7 [karaf]

2024-03-28 Thread via GitHub
jbonofre opened a new pull request, #1830: URL: https://github.com/apache/karaf/pull/1830 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KARAF-7819: Upgrade to Spring 5.2.25_1 feature [karaf]

2024-03-28 Thread via GitHub
jbonofre opened a new pull request, #1828: URL: https://github.com/apache/karaf/pull/1828 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [KARAF-7682] Changed handling of the TCP connection to send the stop command [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1717: URL: https://github.com/apache/karaf/pull/1717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Check for annotation in ActionCommand constructor [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1826: URL: https://github.com/apache/karaf/pull/1826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7691 Prevent SocketException on status check [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1827: URL: https://github.com/apache/karaf/pull/1827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [KARAF-7799] Allow merging of org.apache.karaf.features.xml definitions [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1817: URL: https://github.com/apache/karaf/pull/1817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [KARAF-7799] Allow merging of org.apache.karaf.features.xml definitions [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1818: URL: https://github.com/apache/karaf/pull/1818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [KARAF-7763] Bump slf4j to 2.0.9 [karaf]

2024-03-28 Thread via GitHub
jbonofre closed pull request #1780: [KARAF-7763] Bump slf4j to 2.0.9 URL: https://github.com/apache/karaf/pull/1780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [KARAF-7763] Bump slf4j to 2.0.9 [karaf]

2024-03-28 Thread via GitHub
jbonofre commented on PR #1780: URL: https://github.com/apache/karaf/pull/1780#issuecomment-2025227935 I will superseed with an updated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [KARAF-7773] Upgrade to Pax Web 8.0.24 & Jetty 9.4.53.v20231009 [karaf]

2024-03-28 Thread via GitHub
jbonofre commented on PR #1788: URL: https://github.com/apache/karaf/pull/1788#issuecomment-2025225559 I will supersed with an updated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [KARAF-7773] Upgrade to Pax Web 8.0.24 & Jetty 9.4.53.v20231009 [karaf]

2024-03-28 Thread via GitHub
jbonofre closed pull request #1788: [KARAF-7773] Upgrade to Pax Web 8.0.24 & Jetty 9.4.53.v20231009 URL: https://github.com/apache/karaf/pull/1788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KARAF-7804 - provide unique servlet-name when registering http proxy servlets [karaf]

2024-03-28 Thread via GitHub
jbonofre merged PR #1822: URL: https://github.com/apache/karaf/pull/1822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7691 Prevent SocketException on status check [karaf]

2024-03-19 Thread via GitHub
i-thiemann opened a new pull request, #1827: URL: https://github.com/apache/karaf/pull/1827 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Check for annotation in ActionCommand constructor [karaf]

2024-03-18 Thread via GitHub
pingpingy1 opened a new pull request, #1826: URL: https://github.com/apache/karaf/pull/1826 The `ActionCommand` class takes an `actionClass` parameter for its constructor, whose `@Command` annotation accessed in the other methods. Thus, if the provided `actionClass` has no such

Re: [PR] add feature whitelist definition [karaf]

2024-03-03 Thread via GitHub
mhus closed pull request #1077: add feature whitelist definition URL: https://github.com/apache/karaf/pull/1077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add null guard to MavenDownloadTask [karaf]

2024-02-14 Thread via GitHub
jbonofre merged PR #1825: URL: https://github.com/apache/karaf/pull/1825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add null guard to MavenDownloadTask [karaf]

2024-02-13 Thread via GitHub
pingpingy1 opened a new pull request, #1825: URL: https://github.com/apache/karaf/pull/1825 `resolver` is a private property of the class `MavenDownloadTask` that has no corresponding setter method. As such, if `null` is provided as the `resolver` to the constructor, it cannot be

Re: [PR] WIP: [KARAF-7780] Draft feature for Jakarta specs using capability/requirement [karaf]

2024-02-08 Thread via GitHub
jbonofre commented on PR #1795: URL: https://github.com/apache/karaf/pull/1795#issuecomment-1935447503 I have it, testing it on camel-karaf (on my `REFACTORE` branch). I will have the PR soon, validated with camel-karaf (Camel 4.x using Jakarta namespace only). Give me a couple of days.

Re: [PR] WIP: [KARAF-7780] Draft feature for Jakarta specs using capability/requirement [karaf]

2024-02-08 Thread via GitHub
mattrpav commented on PR #1795: URL: https://github.com/apache/karaf/pull/1795#issuecomment-1935280467 @jbonofre any update on jakarta spec support? I think this PR is close and provides the benefit of separating spec api from impl. Thoughts? -- This is an automated message from the

Re: [PR] Fix typo in README.md [karaf-decanter]

2024-02-08 Thread via GitHub
fpapon merged PR #336: URL: https://github.com/apache/karaf-decanter/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix typo in README.md [karaf-decanter]

2024-02-08 Thread via GitHub
GutZuFusss opened a new pull request, #336: URL: https://github.com/apache/karaf-decanter/pull/336 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Support Java 21 in Builder.JavaVersion [karaf]

2024-01-26 Thread via GitHub
rovarga merged PR #1824: URL: https://github.com/apache/karaf/pull/1824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support Java 21 in Builder.JavaVersion [karaf]

2024-01-26 Thread via GitHub
rovarga commented on PR #1824: URL: https://github.com/apache/karaf/pull/1824#issuecomment-1912815341 This should fix this splat observed with maven.compiler.release=21: ``` [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.4.5:assembly

[PR] Support Java 21 in Builder.JavaVersion [karaf]

2024-01-26 Thread via GitHub
rovarga opened a new pull request, #1824: URL: https://github.com/apache/karaf/pull/1824 We have jre-21 defined in jre.properties, but the Builder would not recognize them. Update the enumeration and eliminate manuall-maintained ordinal, deferring to Enum.compareTo() instead.

Re: [PR] Backport Java 21 support [karaf]

2024-01-26 Thread via GitHub
rovarga closed pull request #1823: Backport Java 21 support URL: https://github.com/apache/karaf/pull/1823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Backport Java 21 support [karaf]

2024-01-26 Thread via GitHub
rovarga opened a new pull request, #1823: URL: https://github.com/apache/karaf/pull/1823 - [KARAF-7761] Upgrade maven-resources-plugin to 3.3.1 - [KARAF-7760] Upgrade maven-source-plugin to 3.3.0 - [KARAF-7759] Upgrade maven-remote-resources-plugin to 3.1.0 - [KARAF-7758]: Upgrade

Re: [PR] KARAF-7804 - provide unique servlet-name when registering http proxy servlets [karaf]

2024-01-26 Thread via GitHub
awrb commented on PR #1822: URL: https://github.com/apache/karaf/pull/1822#issuecomment-1912064664 In the Jira ticket I explain the rationale behind this. For the servlet-name I think simply the proxy URL could be used (without slash), e.g. when proxying to `/external-api` the unique proxy

[PR] KARAF-7804 - provide unique servlet-name when registering http proxy servlets [karaf]

2024-01-26 Thread via GitHub
awrb opened a new pull request, #1822: URL: https://github.com/apache/karaf/pull/1822 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] allow using `overrides.properties` while generating repositories [karaf]

2024-01-18 Thread via GitHub
RangerRick opened a new pull request, #1821: URL: https://github.com/apache/karaf/pull/1821 This PR adds support for using `overrides.properties` when using the `features-add-to-repository` mojo. This allows you to generate a repository that doesn't contain extraneous bundles that won't be

Re: [PR] [KARAF-7758] Remove forkMode parameter [karaf]

2024-01-15 Thread via GitHub
jbonofre merged PR #1819: URL: https://github.com/apache/karaf/pull/1819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [KARAF-7800] Upgrade asciidoctor-maven-plugin to 2.2.5 [karaf]

2024-01-15 Thread via GitHub
jbonofre merged PR #1820: URL: https://github.com/apache/karaf/pull/1820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [KARAF-7799] Allow merging of org.apache.karaf.features.xml definitions [karaf]

2024-01-15 Thread via GitHub
grgrzybek opened a new pull request, #1818: URL: https://github.com/apache/karaf/pull/1818 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] [KARAF-7799] Allow merging of org.apache.karaf.features.xml definitions [karaf]

2024-01-15 Thread via GitHub
grgrzybek opened a new pull request, #1817: URL: https://github.com/apache/karaf/pull/1817 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] [KARAF-7768] Remove org/apache/karaf/specs [karaf]

2024-01-13 Thread via GitHub
rovarga opened a new pull request, #1816: URL: https://github.com/apache/karaf/pull/1816 specs.locator and related logic just dances around the need to integrate with ServiceLoader. In OSGi world that's properly done with adding the appropriate metadata and therefore this magic should not

Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]

2024-01-13 Thread via GitHub
rovarga commented on PR #1784: URL: https://github.com/apache/karaf/pull/1784#issuecomment-1890765848 This PR does the wrong thing, I will raise another one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]

2024-01-13 Thread via GitHub
rovarga closed pull request #1784: [KARAF-7768]: Provide SPI Fly from framework URL: https://github.com/apache/karaf/pull/1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]

2024-01-13 Thread via GitHub
rovarga commented on code in PR #1784: URL: https://github.com/apache/karaf/pull/1784#discussion_r1451604246 ## assemblies/features/framework/src/main/feature/feature.xml: ## @@ -45,6 +45,20 @@

Re: [PR] [KARAF-7798] Document potential need for escape char to wrap deployer [karaf]

2024-01-12 Thread via GitHub
jbonofre merged PR #1815: URL: https://github.com/apache/karaf/pull/1815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [KARAF-7798] Document potential need for escape char to wrap deployer [karaf]

2024-01-12 Thread via GitHub
paulsp opened a new pull request, #1815: URL: https://github.com/apache/karaf/pull/1815 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-6210: extract core config commands to its own bundle [karaf]

2024-01-08 Thread via GitHub
RangerRick commented on PR #1804: URL: https://github.com/apache/karaf/pull/1804#issuecomment-1881814441 @jbonofre Awesome, thanks! I got backed up over the holidays and never had a chance to look further but I was going down the same path (although not as in-depth as what you ended up

Re: [PR] KARAF-7775: Move config shell commands in a dedicated bundle [karaf]

2024-01-04 Thread via GitHub
jbonofre merged PR #1814: URL: https://github.com/apache/karaf/pull/1814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-7775: Move config shell commands in a dedicated bundle [karaf]

2024-01-03 Thread via GitHub
jbonofre commented on PR #1814: URL: https://github.com/apache/karaf/pull/1814#issuecomment-1876489783 I'm fixing the `ConfigManagedServiceFactoryTest` test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KARAF-6210: extract core config commands to its own bundle [karaf]

2024-01-03 Thread via GitHub
jbonofre commented on PR #1804: URL: https://github.com/apache/karaf/pull/1804#issuecomment-1875618334 Superseded by #1814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] KARAF-7775: Move config shell commands in a dedicated bundle [karaf]

2024-01-03 Thread via GitHub
jbonofre opened a new pull request, #1814: URL: https://github.com/apache/karaf/pull/1814 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7793: Upgrade to PAX Logging 2.2.6 [karaf]

2024-01-03 Thread via GitHub
jbonofre merged PR #1813: URL: https://github.com/apache/karaf/pull/1813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KARAF-6210: extract core config commands to its own bundle [karaf]

2024-01-03 Thread via GitHub
jbonofre commented on PR #1804: URL: https://github.com/apache/karaf/pull/1804#issuecomment-1875530587 @RangerRick I found other issue with your bundles: the import required impl package which is private, it should not export utils, etc. I propose to close this one and do a clean new one.

Re: [PR] KARAF-6210: extract core config commands to its own bundle [karaf]

2024-01-03 Thread via GitHub
jbonofre closed pull request #1804: KARAF-6210: extract core config commands to its own bundle URL: https://github.com/apache/karaf/pull/1804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] KARAF-7793: Upgrade to PAX Logging 2.2.6 [karaf]

2024-01-03 Thread via GitHub
jbonofre opened a new pull request, #1813: URL: https://github.com/apache/karaf/pull/1813 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7769: Upgrade to Felix WebConsole 4.8.12 [karaf]

2024-01-03 Thread via GitHub
jbonofre merged PR #1812: URL: https://github.com/apache/karaf/pull/1812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7769: Upgrade to Felix WebConsole 4.8.12 [karaf]

2024-01-03 Thread via GitHub
jbonofre opened a new pull request, #1812: URL: https://github.com/apache/karaf/pull/1812 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-6210: extract core config commands to its own bundle [karaf]

2023-12-24 Thread via GitHub
RangerRick commented on PR #1804: URL: https://github.com/apache/karaf/pull/1804#issuecomment-1868553682 Yeah I got stuck working on other things before the holidays, I realized that as soon as I saw the build failures. Was gonna take another look in the new year but if it's a quick fix

Re: [PR] KARAF-6210: extract core config commands to its own bundle [karaf]

2023-12-23 Thread via GitHub
jbonofre commented on PR #1804: URL: https://github.com/apache/karaf/pull/1804#issuecomment-1868439374 @RangerRick your change on the feature doesn't validate. It should be using conditional. If you don't mind, I will do the change/fix for you. -- This is an automated message from the

Re: [PR] [KARAF-7544] Clean up Jetty/servlet-api use [karaf]

2023-12-19 Thread via GitHub
asfgit closed pull request #1809: [KARAF-7544] Clean up Jetty/servlet-api use URL: https://github.com/apache/karaf/pull/1809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KARAF-7783: Upgrade to commons-logging 1.3.0 [karaf]

2023-12-19 Thread via GitHub
jbonofre merged PR #1811: URL: https://github.com/apache/karaf/pull/1811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support Java 21 in Builder.JavaVersion [karaf]

2023-12-19 Thread via GitHub
jbonofre merged PR #1810: URL: https://github.com/apache/karaf/pull/1810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [KARAF-7754] Target Java 11 [karaf]

2023-12-18 Thread via GitHub
rovarga closed pull request #1781: [KARAF-7754] Target Java 11 URL: https://github.com/apache/karaf/pull/1781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [KARAF-7754] Target Java 11 [karaf]

2023-12-18 Thread via GitHub
rovarga commented on PR #1781: URL: https://github.com/apache/karaf/pull/1781#issuecomment-1860940576 Ah, yeah, I think this needs a lot more work. I will open a new PR once we are ready to take this step. -- This is an automated message from the Apache Git Service. To respond to the

[PR] KARAF-7783: Upgrade to commons-logging 1.3.0 [karaf]

2023-12-18 Thread via GitHub
jbonofre opened a new pull request, #1811: URL: https://github.com/apache/karaf/pull/1811 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [KARAF-7544] Clean up Jetty/servlet-api use [karaf]

2023-12-16 Thread via GitHub
jbonofre commented on PR #1809: URL: https://github.com/apache/karaf/pull/1809#issuecomment-1859049339 FYI: it's what we had before but we changed that as Jetty and servlet api is provided by Pax Web. However, for backward compatibility we add a meta feature. In Karaf 4.5.x, we can

Re: [PR] [KARAF-7544] Clean up Jetty/servlet-api use [karaf]

2023-12-16 Thread via GitHub
jbonofre commented on PR #1809: URL: https://github.com/apache/karaf/pull/1809#issuecomment-1859049128 I will do a manual merge to test and squash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [KARAF-7754] Target Java 11 [karaf]

2023-12-16 Thread via GitHub
jbonofre commented on PR #1781: URL: https://github.com/apache/karaf/pull/1781#issuecomment-1859048691 It doesn't work for verify goal with this change. The verify mojo should be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [KARAF-7766] Require Java 11 at runtime [karaf]

2023-12-16 Thread via GitHub
jbonofre merged PR #1782: URL: https://github.com/apache/karaf/pull/1782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [KARAF-7766] Require Java 11 at runtime [karaf]

2023-12-16 Thread via GitHub
mattrpav commented on PR #1782: URL: https://github.com/apache/karaf/pull/1782#issuecomment-1858827365 @rovarga does this fix the script error about "[" being misused? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Support Java 21 in Builder.JavaVersion [karaf]

2023-12-16 Thread via GitHub
rovarga opened a new pull request, #1810: URL: https://github.com/apache/karaf/pull/1810 We have jre-21 defined in jre.properties, but the Builder would not recognize them. Update the enumeration and eliminate manuall-maintained ordinal, deferring to Enum.compareTo() instead.

Re: [PR] KARAF-7727: Fix org.osgi.util.promise version and use properties [karaf]

2023-12-16 Thread via GitHub
rovarga merged PR #1808: URL: https://github.com/apache/karaf/pull/1808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KARAF-7727: Fix org.osgi.util.promise version and use properties [karaf]

2023-12-15 Thread via GitHub
jbonofre opened a new pull request, #1808: URL: https://github.com/apache/karaf/pull/1808 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KARAF-7781: Upgrade to maven-plugin-annotations 3.10.2 [karaf]

2023-12-15 Thread via GitHub
jbonofre merged PR #1807: URL: https://github.com/apache/karaf/pull/1807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   5   >