This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new fdb42489d [build] Fix RocksDB Snappy dependency.
fdb42489d is described below
commit fdb42489d76098eeca371ac57ae02ea176438c64
Author: Zoltan Martonka <zmarto...@gmail.com>
AuthorDate: Tue Apr 30 07:25:45 2024 +0000
[build] Fix RocksDB Snappy dependency.
RocksDB uses Snappy. When statically linking Kudu, librocksdb.a contains
multiple undefined symbols that are defined in libsnappy.a. In the case
of static linking, the order of libraries passed to the linker matters,
and libsnappy.a must come after librocksdb.a. This sometimes causes the
release build to fail on RHEL 9.3.
Change-Id: I3ce75f69d94436f732dbe9a0011546b1ae494824
Reviewed-on: http://gerrit.cloudera.org:8080/21370
Reviewed-by: Attila Bukor <abu...@apache.org>
Tested-by: Attila Bukor <abu...@apache.org>
---
CMakeLists.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index d4c9f4fc7..c13d7743a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1283,7 +1283,8 @@ find_package(Rocksdb REQUIRED)
include_directories(SYSTEM ${ROCKSDB_INCLUDE_DIR})
ADD_THIRDPARTY_LIB(rocksdb
STATIC_LIB "${ROCKSDB_STATIC_LIB}"
- SHARED_LIB "${ROCKSDB_SHARED_LIB}")
+ SHARED_LIB "${ROCKSDB_SHARED_LIB}"
+ DEPS snappy)
############################################################
# Enable sized deallocation where supported.
