Fix the collectl example and add encodings
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/75b08098 Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/75b08098 Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/75b08098 Branch: refs/heads/master Commit: 75b08098e9449f6f5f3f162aa944783cfe10d681 Parents: aac4a91 Author: David Alves <david.al...@cloudera.com> Authored: Sun Sep 27 19:31:48 2015 -0700 Committer: David Alves <david.al...@cloudera.com> Committed: Sun Sep 27 19:41:23 2015 -0700 ---------------------------------------------------------------------- .../examples/collectl/KuduCollectlExample.java | 30 ++++++++++++-------- 1 file changed, 18 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/75b08098/java/collectl/src/main/java/org/kududb/examples/collectl/KuduCollectlExample.java ---------------------------------------------------------------------- diff --git a/java/collectl/src/main/java/org/kududb/examples/collectl/KuduCollectlExample.java b/java/collectl/src/main/java/org/kududb/examples/collectl/KuduCollectlExample.java index effcca2..4480982 100644 --- a/java/collectl/src/main/java/org/kududb/examples/collectl/KuduCollectlExample.java +++ b/java/collectl/src/main/java/org/kududb/examples/collectl/KuduCollectlExample.java @@ -65,10 +65,14 @@ public class KuduCollectlExample { } ArrayList<ColumnSchema> cols = new ArrayList<>(); - cols.add(new ColumnSchemaBuilder("host", Type.STRING).key(true).build()); - cols.add(new ColumnSchemaBuilder("metric", Type.STRING).key(true).build()); - cols.add(new ColumnSchemaBuilder("timestamp", Type.INT32).key(true).build()); - cols.add(new ColumnSchemaBuilder("value", Type.DOUBLE).build()); + cols.add(new ColumnSchemaBuilder("host", Type.STRING).key(true).encoding( + ColumnSchema.Encoding.DICT_ENCODING).build()); + cols.add(new ColumnSchemaBuilder("metric", Type.STRING).key(true).encoding( + ColumnSchema.Encoding.DICT_ENCODING).build()); + cols.add(new ColumnSchemaBuilder("timestamp", Type.INT32).key(true).encoding( + ColumnSchema.Encoding.BIT_SHUFFLE).build()); + cols.add(new ColumnSchemaBuilder("value", Type.DOUBLE) + .encoding(ColumnSchema.Encoding.BIT_SHUFFLE).build()); client.createTable(TABLE_NAME, new Schema(cols)); } @@ -163,15 +167,17 @@ public class KuduCollectlExample { if (!br.ready()) { List<OperationResponse> responses = session.flush(); for (OperationResponse r : responses) { - RowError e = r.getRowError(); - // TODO: the client should offer an enum for different row errors, instead - // of string comparison! - if ("ALREADY_PRESENT".equals(e.getStatus())) { - continue; - } - System.err.println("Error inserting " + e.getOperation().toString() - + ": " + e.toString()); + if (r.hasRowError()) { + RowError e = r.getRowError(); + // TODO: the client should offer an enum for different row errors, instead + // of string comparison! + if ("ALREADY_PRESENT".equals(e.getStatus())) { + continue; + } + System.err.println("Error inserting " + e.getOperation().toString() + + ": " + e.toString()); } + } } } }
