Add TODO Added TODOs
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e45e82fc Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e45e82fc Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e45e82fc Branch: refs/heads/LOG4J2-1010&LOG4J2-1447-injectable-contextdata&better-datastructure Commit: e45e82fc9156c37b5b5aafdb59f3d43f3fc75422 Parents: cda3928 Author: Mikael Ståldal <mikael.stal...@magine.com> Authored: Tue Jun 28 17:40:34 2016 +0200 Committer: Mikael Ståldal <mikael.stal...@magine.com> Committed: Wed Jun 29 10:55:36 2016 +0200 ---------------------------------------------------------------------- .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala | 5 ++++- .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala ---------------------------------------------------------------------- diff --git a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala index c662ef1..8fe926c 100644 --- a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala +++ b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala @@ -60,7 +60,7 @@ object Logger { * Since this wrapper is implemented with macros, the String construction and method invocations * will only occur when debug logging is enabled. */ -class Logger private(val delegate: ExtendedLogger) { +class Logger private(val delegate: ExtendedLogger) { // TODO extends AnyVal ? private final val FQCN = classOf[Logger].getName @@ -619,6 +619,9 @@ class Logger private(val delegate: ExtendedLogger) { delegate.logMessage(FQCN, level, marker, messageFactory.newMessage(message), cause) } + + // TODO inline those to get FQCN correct? make macro of other trace methods as well + /** Should normally not be used directly from application code, but needs to be public for access by macros. */ def traceEntryParams(params: Any*): EntryMessage = { delegate.traceEntry(null, params) // TODO should not do ifEnabled check http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala ---------------------------------------------------------------------- diff --git a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala index c662ef1..f58b8df 100644 --- a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala +++ b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala @@ -431,7 +431,7 @@ class Logger private(val delegate: ExtendedLogger) { def isEnabled(level: Level, marker: Marker): Boolean = delegate.isEnabled(level, marker) - // TODO fix FQCN for flow logging + // TODO fix FQCN for flow logging - Break out flow logging logic from AbstractLogger into somethimg accessible from Scala API ? /** * Logs entry to a method. Used when the method in question has no parameters or when the parameters should not be
