Updated Branches:
  refs/heads/master 2210a9e52 -> 94f594869

Cleaned up strings::tokenize.

Trivial cleanup of Stout's tokenize function.

Also, this is last change I needed to get Clang Static Analyzer to build and 
analyze Mesos on Ubuntu 13.04.
(It was complaining about offset never being read after offset = s.length();).

From: David Mackey <tdmac...@booleanhaiku.com>
Review: https://reviews.apache.org/r/14288


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/07fe3bfc
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/07fe3bfc
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/07fe3bfc

Branch: refs/heads/master
Commit: 07fe3bfcd677e05097b423c9dc28734d56d98c8c
Parents: 2210a9e
Author: Benjamin Mahler <bmah...@twitter.com>
Authored: Mon Sep 23 16:20:10 2013 -0700
Committer: Benjamin Mahler <bmah...@twitter.com>
Committed: Mon Sep 23 16:20:10 2013 -0700

----------------------------------------------------------------------
 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/07fe3bfc/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
b/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
index ed14106..46a0a26 100644
--- a/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
+++ b/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
@@ -93,8 +93,7 @@ inline std::vector<std::string> tokenize(
   while (true) {
     size_t i = s.find_first_not_of(delims, offset);
     if (std::string::npos == i) {
-      offset = s.length();
-      return tokens;
+      break;
     }
 
     size_t j = s.find_first_of(delims, i);

Reply via email to