Added logging when `Offer::Operation::Launch` has no tasks. Added a implict decline warning message when an offer is accepted by a framework without specifying any task to be launched.
Review: https://reviews.apache.org/r/49239/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f69a27c4 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f69a27c4 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f69a27c4 Branch: refs/heads/master Commit: f69a27c43eaf9ade386819dd707ce33041ee1f20 Parents: a853cc2 Author: Jose Guilherme Vanz <guilherme....@gmail.com> Authored: Thu Jul 21 13:36:16 2016 -0700 Committer: Anand Mazumdar <an...@apache.org> Committed: Thu Jul 21 13:36:16 2016 -0700 ---------------------------------------------------------------------- src/master/master.cpp | 3 +++ 1 file changed, 3 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/f69a27c4/src/master/master.cpp ---------------------------------------------------------------------- diff --git a/src/master/master.cpp b/src/master/master.cpp index f2b803d..b87d18f 100644 --- a/src/master/master.cpp +++ b/src/master/master.cpp @@ -3378,6 +3378,9 @@ void Master::accept( ++metrics->messages_launch_tasks; } else { ++metrics->messages_decline_offers; + LOG(WARNING) << "Implicitly declining offers: " << accept.offer_ids() + << " in ACCEPT call for framework " << framework->id() + << " as the launch operation specified no tasks"; } }
