[mesos] 01/03: Added missing `return` statement in `Slave::statusUpdate`.
This is an automated email from the ASF dual-hosted git repository. abudnik pushed a commit to branch 1.8.x in repository https://gitbox.apache.org/repos/asf/mesos.git commit 14abb82925cdbce746238bc20dc7b8c279a96a67 Author: Andrei Budnik AuthorDate: Fri Aug 23 14:36:18 2019 +0200 Added missing `return` statement in `Slave::statusUpdate`. Previously, if `statusUpdate` was called for a pending task, it would forward the status update and then continue executing `statusUpdate`, which then checks if there is an executor that is aware of this task. Given that a pending task is not known to any executor, it would always handle it by forwarding status update one more time. This patch adds missing `return` statement, which fixes the issue. Review: https://reviews.apache.org/r/71361 --- src/slave/slave.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/slave/slave.cpp b/src/slave/slave.cpp index bf87be0..50a7d68 100644 --- a/src/slave/slave.cpp +++ b/src/slave/slave.cpp @@ -5659,6 +5659,8 @@ void Slave::statusUpdate(StatusUpdate update, const Option& pid) taskStatusUpdateManager->update(update, info.id()) .onAny(defer(self(), ::___statusUpdate, lambda::_1, update, pid)); + +return; } Executor* executor = framework->getExecutor(status.task_id());
[mesos] 01/03: Added missing `return` statement in `Slave::statusUpdate`.
This is an automated email from the ASF dual-hosted git repository. abudnik pushed a commit to branch 1.7.x in repository https://gitbox.apache.org/repos/asf/mesos.git commit 2d62e8ae0ef94f78c9b32be258a08d1e6e2382df Author: Andrei Budnik AuthorDate: Fri Aug 23 14:36:18 2019 +0200 Added missing `return` statement in `Slave::statusUpdate`. Previously, if `statusUpdate` was called for a pending task, it would forward the status update and then continue executing `statusUpdate`, which then checks if there is an executor that is aware of this task. Given that a pending task is not known to any executor, it would always handle it by forwarding status update one more time. This patch adds missing `return` statement, which fixes the issue. Review: https://reviews.apache.org/r/71361 --- src/slave/slave.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/slave/slave.cpp b/src/slave/slave.cpp index 1c33579..edfe3d0 100644 --- a/src/slave/slave.cpp +++ b/src/slave/slave.cpp @@ -5418,6 +5418,8 @@ void Slave::statusUpdate(StatusUpdate update, const Option& pid) taskStatusUpdateManager->update(update, info.id()) .onAny(defer(self(), ::___statusUpdate, lambda::_1, update, pid)); + +return; } Executor* executor = framework->getExecutor(status.task_id());
[mesos] 01/03: Added missing `return` statement in `Slave::statusUpdate`.
This is an automated email from the ASF dual-hosted git repository. abudnik pushed a commit to branch 1.6.x in repository https://gitbox.apache.org/repos/asf/mesos.git commit cc79f22fb07cfad8f248150d5a3040f846998c3a Author: Andrei Budnik AuthorDate: Fri Aug 23 14:36:18 2019 +0200 Added missing `return` statement in `Slave::statusUpdate`. Previously, if `statusUpdate` was called for a pending task, it would forward the status update and then continue executing `statusUpdate`, which then checks if there is an executor that is aware of this task. Given that a pending task is not known to any executor, it would always handle it by forwarding status update one more time. This patch adds missing `return` statement, which fixes the issue. Review: https://reviews.apache.org/r/71361 --- src/slave/slave.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/slave/slave.cpp b/src/slave/slave.cpp index 2a90e96..176d3fb 100644 --- a/src/slave/slave.cpp +++ b/src/slave/slave.cpp @@ -5388,6 +5388,8 @@ void Slave::statusUpdate(StatusUpdate update, const Option& pid) taskStatusUpdateManager->update(update, info.id()) .onAny(defer(self(), ::___statusUpdate, lambda::_1, update, pid)); + +return; } Executor* executor = framework->getExecutor(status.task_id());
