[GitHub] piiswrong commented on a change in pull request #9986: gluon language modeling dataset and text token reader

2018-03-05 Thread GitBox
piiswrong commented on a change in pull request #9986: gluon language modeling dataset and text token reader URL: https://github.com/apache/incubator-mxnet/pull/9986#discussion_r172287751 ## File path: python/mxnet/gluon/utils.py ## @@ -218,3 +220,25 @@ def download(url, p

[GitHub] piiswrong commented on a change in pull request #9986: gluon language modeling dataset and text token reader

2018-03-05 Thread GitBox
piiswrong commented on a change in pull request #9986: gluon language modeling dataset and text token reader URL: https://github.com/apache/incubator-mxnet/pull/9986#discussion_r172287545 ## File path: python/mxnet/gluon/data/text/lm.py ## @@ -0,0 +1,157 @@ +# Licensed to

[GitHub] piiswrong commented on a change in pull request #9986: gluon language modeling dataset and text token reader

2018-03-05 Thread GitBox
piiswrong commented on a change in pull request #9986: gluon language modeling dataset and text token reader URL: https://github.com/apache/incubator-mxnet/pull/9986#discussion_r172284551 ## File path: python/mxnet/gluon/data/datareader.py ## @@ -0,0 +1,33 @@ +# Licensed t

[GitHub] sergeykolychev commented on a change in pull request #9995: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
sergeykolychev commented on a change in pull request #9995: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r172283386 ## File path: ci/docker/install/ubuntu_perl.sh ## @@ -0,0 +1,26 @@ +#!/bin/bash + +# Licensed to

[GitHub] piiswrong commented on issue #9986: gluon language modeling dataset and text token reader

2018-03-05 Thread GitBox
piiswrong commented on issue #9986: gluon language modeling dataset and text token reader URL: https://github.com/apache/incubator-mxnet/pull/9986#issuecomment-370515207 I think it's better to merge all of the core NLP package at once. We don't want half of it in 1.2 and the other half in

[GitHub] piiswrong commented on issue #9977: Cpu lstm inference

2018-03-05 Thread GitBox
piiswrong commented on issue #9977: Cpu lstm inference URL: https://github.com/apache/incubator-mxnet/pull/9977#issuecomment-370514828 We don't have to do the refactor now. CPU support is more important. This is an automated m

[GitHub] piiswrong commented on issue #9990: Update tensorboard.py

2018-03-05 Thread GitBox
piiswrong commented on issue #9990: Update tensorboard.py URL: https://github.com/apache/incubator-mxnet/pull/9990#issuecomment-370511215 @zihaolucky This is an automated message from the Apache Git Service. To respond to the

[GitHub] piiswrong commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
piiswrong commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370509268 Numpy shuffles along the first axis: https://docs.scipy.org/doc/numpy/reference/generated/numpy.random.shuffle.html We should comply with

[GitHub] piiswrong commented on a change in pull request #9994: Tensorboard: Add histogram callback

2018-03-05 Thread GitBox
piiswrong commented on a change in pull request #9994: Tensorboard: Add histogram callback URL: https://github.com/apache/incubator-mxnet/pull/9994#discussion_r172276154 ## File path: python/mxnet/contrib/tensorboard.py ## @@ -71,3 +72,43 @@ def __call__(self, param):

[GitHub] zheng-da commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API

2018-03-05 Thread GitBox
zheng-da commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API URL: https://github.com/apache/incubator-mxnet/issues/9921#issuecomment-370499893 I don't understand how much benefit `update_on_kvstore=False` provides. Why does`update_on_kvstore=False` or `update_on_kvstore=

[GitHub] larroy commented on issue #9993: cmake cannot build mxnet

2018-03-05 Thread GitBox
larroy commented on issue #9993: cmake cannot build mxnet URL: https://github.com/apache/incubator-mxnet/issues/9993#issuecomment-370492031 The logic in CMakeLists.txt is bad, having mkldnn as is part of 3rdparty doesn't mean that you have MKL which is not open source. ---

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370486626 `test_bmod` fails in `Python3: MKLDNN-CPU` (http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-9991/3/pi

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370486626 `test_bmod` fails in `Python3: MKLDNN-CPU` (http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-9991/3/pi

[GitHub] larroy commented on issue #9993: cmake cannot build mxnet

2018-03-05 Thread GitBox
larroy commented on issue #9993: cmake cannot build mxnet URL: https://github.com/apache/incubator-mxnet/issues/9993#issuecomment-370486503 @marcoabreu @cjolivier01 as we spoke with Marco in person, I don't think we should compile with MKL by default if we don't even know if there's MKL

[GitHub] szha commented on a change in pull request #9928: host doc on s3

2018-03-05 Thread GitBox
szha commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r172253115 ## File path: tests/ci_build/deploy/aws ## @@ -0,0 +1,29 @@ +#!/usr/bin/env python Review comment: This is a copy of the dri

[GitHub] zheng-da commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-05 Thread GitBox
zheng-da commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-370476970 @cjolivier01 Is there a tutorial for this improvement? -

[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3

2018-03-05 Thread GitBox
marcoabreu commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r172245084 ## File path: tests/ci_build/deploy/aws ## @@ -0,0 +1,29 @@ +#!/usr/bin/env python Review comment: This file has no ty

[GitHub] marcoabreu commented on issue #9928: host doc on s3

2018-03-05 Thread GitBox
marcoabreu commented on issue #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#issuecomment-370476827 Awesome, great job sheng! This is an automated message from the Apache Git Service. To respond

[GitHub] szha commented on issue #9928: host doc on s3

2018-03-05 Thread GitBox
szha commented on issue #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#issuecomment-370473606 Now the doc is hosted at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-9928/25/index.html ---

[GitHub] larroy commented on issue #9993: cmake cannot build mxnet

2018-03-05 Thread GitBox
larroy commented on issue #9993: cmake cannot build mxnet URL: https://github.com/apache/incubator-mxnet/issues/9993#issuecomment-370471642 The exact error is: ``` In file included from /home/piotr/devel/mxnet_build/src/operator/nn/dropout.cu:27:0: /home/piotr/devel/mxnet_buil

[GitHub] larroy commented on issue #9993: cmake cannot build mxnet

2018-03-05 Thread GitBox
larroy commented on issue #9993: cmake cannot build mxnet URL: https://github.com/apache/incubator-mxnet/issues/9993#issuecomment-370471397 I was able to reproduce. This is an automated message from the Apache Git Service. To

[GitHub] szha commented on issue #9977: Cpu lstm inference

2018-03-05 Thread GitBox
szha commented on issue #9977: Cpu lstm inference URL: https://github.com/apache/incubator-mxnet/pull/9977#issuecomment-370471304 Pinging @piiswrong for coordination. This is an automated message from the Apache Git Service. T

[GitHub] wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-05 Thread GitBox
wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#issuecomment-370447850 @marcoabreu The reason to add USE_STABLE_SORT_FOR_PROPOSAL flag is for the cpu/gpu consi

[GitHub] marcoabreu closed pull request #9946: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
marcoabreu closed pull request #9946: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9946 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] marcoabreu opened a new pull request #9995: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
marcoabreu opened a new pull request #9995: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9995 TODO: Description The following jobs will have to be migrated or will be added as part of this process. ## Sanity Check - [ ] Sanity C

[GitHub] marcoabreu commented on issue #9946: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
marcoabreu commented on issue #9946: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9946#issuecomment-370453026 New PR: https://github.com/apache/incubator-mxnet/pull/9995 This is an

[GitHub] wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-05 Thread GitBox
wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#issuecomment-370447850 @marcoabreu The reason to add USE_STABLE_SORT_FOR_PROPOSAL flag is for the cpu/gpu consi

[GitHub] wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-05 Thread GitBox
wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#issuecomment-370447850 @marcoabreu The reason to add USE_STABLE_SORT_FOR_PROPOSAL flag is for the cpu/gpu consi

[GitHub] wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-05 Thread GitBox
wkcn commented on issue #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#issuecomment-370447850 @marcoabreu The reason to add USE_STABLE_SORT_FOR_PROPOSAL flag is for the cpu/gpu consi

[GitHub] YujiOshima opened a new pull request #9994: Tensorboard: Add histogram callback

2018-03-05 Thread GitBox
YujiOshima opened a new pull request #9994: Tensorboard: Add histogram callback URL: https://github.com/apache/incubator-mxnet/pull/9994 ## Description ## Add visualize histograms and distributions of each layer in Tensorboard. You can use `contrib.tensorboard.LogMetricsCallback.node_

[incubator-mxnet] branch master updated: Non-blocking row_sparse_pull. Fix incorrect indices generated by device kvstore.row_sparse_pull (#9887)

2018-03-05 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 02dd89a Non-blocking row_sparse_pull.

[GitHub] eric-haibin-lin closed pull request #9887: Non-blocking row_sparse_pull. Fix incorrect indices generated by device kvstore.row_sparse_pull

2018-03-05 Thread GitBox
eric-haibin-lin closed pull request #9887: Non-blocking row_sparse_pull. Fix incorrect indices generated by device kvstore.row_sparse_pull URL: https://github.com/apache/incubator-mxnet/pull/9887 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[GitHub] marcoabreu commented on a change in pull request #9946: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
marcoabreu commented on a change in pull request #9946: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9946#discussion_r172190039 ## File path: ci/build.py ## @@ -69,7 +69,7 @@ def build_docker(platform: str, docker_binary: str) -

[GitHub] larroy commented on a change in pull request #9946: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
larroy commented on a change in pull request #9946: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9946#discussion_r172188798 ## File path: ci/build.py ## @@ -69,7 +69,7 @@ def build_docker(platform: str, docker_binary: str) -> No

[GitHub] larroy commented on issue #9946: [DO NOT MERGE] Start CI docker revamp

2018-03-05 Thread GitBox
larroy commented on issue #9946: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9946#issuecomment-370420641 Maybe we should reopen this PR from our private mxnet repo so we can both push... -

[GitHub] qingyuanxingsi commented on issue #9944: MXNet MinGW-w64 build error

2018-03-05 Thread GitBox
qingyuanxingsi commented on issue #9944: MXNet MinGW-w64 build error URL: https://github.com/apache/incubator-mxnet/issues/9944#issuecomment-370402086 @lebeg When can the windows build be fixed??Actually I do need the cpp package! Inform me if fixed, much thanks! -

[GitHub] xinyu-intel commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
xinyu-intel commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172147846 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9 @@ RU

[GitHub] jacky4323 opened a new issue #9993: cmake cannot build mxnet now

2018-03-05 Thread GitBox
jacky4323 opened a new issue #9993: cmake cannot build mxnet now URL: https://github.com/apache/incubator-mxnet/issues/9993 command I use $git clone --recursive https://github.com/apache/incubator-mxnet.git $cd incubator-mxnet/ $mkdir build/Release && cd build/Release $cmake ../.

[GitHub] KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172146416 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9

[GitHub] KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172146416 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9

[GitHub] KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172146416 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9

[GitHub] xinyu-intel commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
xinyu-intel commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172141114 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9 @@ RU

[GitHub] KellenSunderland commented on issue #9963: Onnx Module to import onnx models into mxnet

2018-03-05 Thread GitBox
KellenSunderland commented on issue #9963: Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#issuecomment-370373166 Hi @anirudhacharya, are you blocked by the CI change? You are able to change the CI process along with your PR, and insta

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370372706 @cjolivier01 This operator uses the random number generator obtained through `ResourceRequest::kRandom`. So it shares the random number state wi

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370372706 @cjolivier01 This operator uses the random number generator obtained with `ResourceRequest::kRandom`. So it shares the random number state with

[GitHub] KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
KellenSunderland commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172137816 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9

[GitHub] marcoabreu commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-05 Thread GitBox
marcoabreu commented on a change in pull request #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r172128856 ## File path: tests/ci_build/Dockerfile.cpu_clang ## @@ -19,3 +19,9 @@ RUN

[GitHub] marcoabreu commented on issue #9981: [fix issue#9976] The assignment problem in NDArray

2018-03-05 Thread GitBox
marcoabreu commented on issue #9981: [fix issue#9976] The assignment problem in NDArray URL: https://github.com/apache/incubator-mxnet/pull/9981#issuecomment-370357076 @piiswrong you can always retrigger a test by logging in at http://jenkins.mxnet-ci.amazon-ml.com/ (committers only)

[GitHub] dytmh opened a new issue #9992: mxnet scala example run error

2018-03-05 Thread GitBox
dytmh opened a new issue #9992: mxnet scala example run error URL: https://github.com/apache/incubator-mxnet/issues/9992 Note: Providing complete information in the most concise form is the best way to get help. This issue template serves as the checklist for essential information to most

[GitHub] marcoabreu commented on issue #9803: R Metrics

2018-03-05 Thread GitBox
marcoabreu commented on issue #9803: R Metrics URL: https://github.com/apache/incubator-mxnet/pull/9803#issuecomment-370352723 I'd like to refrain from calling gc() manually as much as possible. In my opinion it would be better if we really track down the root cause. --

[incubator-mxnet] branch master updated: revert DiagrammeR compatibility to 0.9.0 (#9975)

2018-03-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new f973fe0 revert DiagrammeR compatib

[GitHub] marcoabreu closed pull request #9975: revert DiagrammeR compatibility to 0.9.0

2018-03-05 Thread GitBox
marcoabreu closed pull request #9975: revert DiagrammeR compatibility to 0.9.0 URL: https://github.com/apache/incubator-mxnet/pull/9975 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] guruvishnuvardan commented on issue #2869: How to handle video data with an existing image classification network

2018-03-05 Thread GitBox
guruvishnuvardan commented on issue #2869: How to handle video data with an existing image classification network URL: https://github.com/apache/incubator-mxnet/issues/2869#issuecomment-370349233 @phunterlau Hi Can you please help me with error, ![mxnet data_shape](https://user-image

[GitHub] guruvishnuvardan commented on issue #2869: How to handle video data with an existing image classification network

2018-03-05 Thread GitBox
guruvishnuvardan commented on issue #2869: How to handle video data with an existing image classification network URL: https://github.com/apache/incubator-mxnet/issues/2869#issuecomment-370349233 HI Can you please help me with error, ![mxnet data_shape](https://user-images.githubuserc

[GitHub] guruvishnuvardan commented on issue #2294: Variable batch size (number of samples, the dim1) during forward-backward computation

2018-03-05 Thread GitBox
guruvishnuvardan commented on issue #2294: Variable batch size (number of samples, the dim1) during forward-backward computation URL: https://github.com/apache/incubator-mxnet/issues/2294#issuecomment-370346273 @phunterlau - how to define batch size for a video? in mxnet -

[GitHub] TaoLv commented on issue #9977: Cpu lstm inference

2018-03-05 Thread GitBox
TaoLv commented on issue #9977: Cpu lstm inference URL: https://github.com/apache/incubator-mxnet/pull/9977#issuecomment-370341835 @szha Team need take an internal discussion about it and will back to you with a detailed plan soon. BTW, do you know anybody can help to refactor the existi

<    1   2