[GitHub] sandipmgiri closed issue #10100: error: 'kCPU' was not declared in this scope

2018-03-14 Thread GitBox
sandipmgiri closed issue #10100: error: 'kCPU' was not declared in this scope URL: https://github.com/apache/incubator-mxnet/issues/10100 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sandipmgiri commented on issue #10100: error: 'kCPU' was not declared in this scope

2018-03-14 Thread GitBox
sandipmgiri commented on issue #10100: error: 'kCPU' was not declared in this scope URL: https://github.com/apache/incubator-mxnet/issues/10100#issuecomment-373261996 Thanks @TaoLv , After `git submodule update --recursive` the build is working fine.

[GitHub] spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174674051 ## File path: python/mxnet/contrib/onnx/_import/import_onnx.py ## @@ -126,13

[GitHub] spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174673962 ## File path: python/mxnet/contrib/onnx/_import/import_onnx.py ## @@ -126,13

[GitHub] spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174673619 ## File path: python/mxnet/contrib/onnx/_import/import_onnx.py ## @@ -110,6

[GitHub] sxjscience commented on issue #9363: Incorrect weight_decay implementation in AdaGrad

2018-03-14 Thread GitBox
sxjscience commented on issue #9363: Incorrect weight_decay implementation in AdaGrad URL: https://github.com/apache/incubator-mxnet/issues/9363#issuecomment-373255756 OK, we need to reopen it then. Get Outlook for iOS

[GitHub] szha commented on a change in pull request #10120: Update profiler example code

2018-03-14 Thread GitBox
szha commented on a change in pull request #10120: Update profiler example code URL: https://github.com/apache/incubator-mxnet/pull/10120#discussion_r174672622 ## File path: docs/faq/perf.md ## @@ -228,12 +228,12 @@ See

[GitHub] szha commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-14 Thread GitBox
szha commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174672326 ## File path: python/mxnet/profiler.py ## @@ -35,13 +68,16 @@ def

[GitHub] eric-haibin-lin commented on issue #9363: Incorrect weight_decay implementation in AdaGrad

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #9363: Incorrect weight_decay implementation in AdaGrad URL: https://github.com/apache/incubator-mxnet/issues/9363#issuecomment-373251663 No, the change was reverted in the PR. My PR only contains a sparse op with Wd == 0

[GitHub] kenfehling opened a new pull request #10120: Update profiler example code

2018-03-14 Thread GitBox
kenfehling opened a new pull request #10120: Update profiler example code URL: https://github.com/apache/incubator-mxnet/pull/10120 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make

[GitHub] devymex opened a new issue #10119: [BUG] A typo

2018-03-14 Thread GitBox
devymex opened a new issue #10119: [BUG] A typo URL: https://github.com/apache/incubator-mxnet/issues/10119 https://github.com/apache/incubator-mxnet/blob/f7fa49e3068ab30a7379bbce1b288bf285fe5cde/src/operator/swapaxis-inl.h#L113 TBlob data_out = out_data[cvmatdataenum::kData]; should

[GitHub] eric-haibin-lin commented on issue #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#issuecomment-373244595 pls create one This is an automated message from the Apache

[GitHub] feevos commented on issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks

2018-03-14 Thread GitBox
feevos commented on issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks URL: https://github.com/apache/incubator-mxnet/issues/10101#issuecomment-373237657 Hi @szha and @sxjscience thank you very much for

[GitHub] szha commented on issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks

2018-03-14 Thread GitBox
szha commented on issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks URL: https://github.com/apache/incubator-mxnet/issues/10101#issuecomment-373240278 Good point on making the feature known. cc'd

[incubator-mxnet] branch master updated: Compile MKLDNN in Mac. (#10115)

2018-03-14 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new f7fa49e Compile MKLDNN in Mac.

[GitHub] szha closed pull request #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
szha closed pull request #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
szha commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373238530 clang build is different from building on mac. For example, clang build won't catch the processor detection problem.

[GitHub] feevos closed issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks

2018-03-14 Thread GitBox
feevos closed issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks URL: https://github.com/apache/incubator-mxnet/issues/10101 This is an

[GitHub] feevos commented on issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks

2018-03-14 Thread GitBox
feevos commented on issue #10101: gluon feature request: proper registration/initialization of layers inside a list (container) for custom (Hybrid)Blocks URL: https://github.com/apache/incubator-mxnet/issues/10101#issuecomment-373237657 Hi @szha and @sxjscience thank you very much for

[GitHub] TaoLv commented on issue #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
TaoLv commented on issue #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#issuecomment-373237214 BTW, is there any existing jira issue for RNN implementation? Do I need to create a jira issue for this PR? @eric-haibin-lin @Jerryzcn

[GitHub] TaoLv commented on issue #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
TaoLv commented on issue #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#issuecomment-373236475 @Jerryzcn Good suggestion. I will take a try. This is an automated

[GitHub] TaoLv commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
TaoLv commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#discussion_r174660148 ## File path: src/operator/rnn.cc ## @@ -21,38 +21,212 @@ * Copyright (c) 2015 by Contributors *

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174659007 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174658117 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174658718 ## File path: python/mxnet/gluon/text/embedding.py ## @@ -0,0 +1,582 @@ +# Licensed to the Apache Software

[GitHub] pengzhao-intel commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
pengzhao-intel commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373233188 FYI, as @KellenSunderland @marcoabreu 's suggestion, we added Clang + MKLDNN instance in CI process #9918 (#9828) to track the OSX building

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174658117 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174658095 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174658086 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-14 Thread GitBox
nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174657442 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Classifier.scala ## @@ -0,0 +1,167 @@

[GitHub] nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-14 Thread GitBox
nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174657396 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/MXNetHandler.scala ## @@ -0,0 +1,82 @@

[GitHub] rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-03-14 Thread GitBox
rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#issuecomment-373228390 [Example profile where this operation can help. Server process of kvstore during

[GitHub] rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-03-14 Thread GitBox
rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#issuecomment-373228390 ![Example profile where this operation can help. Server process of kvstore during

[GitHub] rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations

2018-03-14 Thread GitBox
rahul003 commented on issue #9029: [MXNET-36] Update ndarray binary ops to use kernel launch instead of mshadow operations URL: https://github.com/apache/incubator-mxnet/pull/9029#issuecomment-373228390 ![Example profile where this operation can help. Server process of kvstore during

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174655150 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174651725 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software

[GitHub] eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r174651088 ## File path: example/rnn/large_word_lm/data.py ## @@ -0,0 +1,202 @@

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174650933 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r174650820 ## File path: example/rnn/large_word_lm/model.py ## @@ -0,0 +1,181

[GitHub] eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r174650752 ## File path: example/rnn/large_word_lm/data.py ## @@ -0,0 +1,202 @@

[GitHub] eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r174650688 ## File path: src/operator/nn/fully_connected.cc ## @@ -56,7 +56,10

[GitHub] eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10025: [MXNET-96] Language model with Google's billion words dataset URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r174650628 ## File path: python/mxnet/gluon/contrib/rnn/rnn_cell.py ## @@

[GitHub] chinakook commented on issue #10097: When to merge mxnet-fold to master?

2018-03-14 Thread GitBox
chinakook commented on issue #10097: When to merge mxnet-fold to master? URL: https://github.com/apache/incubator-mxnet/issues/10097#issuecomment-373221488  This is an automated message from the Apache Git Service. To

[GitHub] chinakook closed issue #10097: When to merge mxnet-fold to master?

2018-03-14 Thread GitBox
chinakook closed issue #10097: When to merge mxnet-fold to master? URL: https://github.com/apache/incubator-mxnet/issues/10097 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174646485 ## File path: tests/python-pytest/onnx/onnx_backend_test.py ## @@

[GitHub] anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174649378 ## File path: tests/python-pytest/onnx/onnx_backend_test.py ## @@

[GitHub] anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174645527 ## File path: python/mxnet/contrib/onnx/_import/import_onnx.py ## @@

[GitHub] anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174645969 ## File path: python/mxnet/contrib/onnx/_import/import_onnx.py ## @@

[GitHub] anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174645462 ## File path: python/mxnet/contrib/onnx/_import/import_onnx.py ## @@

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174646639 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] thinksanky commented on issue #59: Fixed Learn More to the correct landing page

2018-03-14 Thread GitBox
thinksanky commented on issue #59: Fixed Learn More to the correct landing page URL: https://github.com/apache/incubator-mxnet-site/pull/59#issuecomment-373216639 Yes, I thought about this issue, but was planning to follow up with another PR. The idea about this PR is to ensure the Learn

[GitHub] spidyDev opened a new pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

2018-03-14 Thread GitBox
spidyDev opened a new pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator. URL: https://github.com/apache/incubator-mxnet/pull/10118 ## Description ## Return mxnet arg params and aux params separately when importing an onnx model to mxnet. Current

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643877 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643617 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174642866 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643108 ## File path: python/mxnet/gluon/text/embedding.py ## @@ -0,0 +1,582 @@ +# Licensed to the Apache Software

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174642802 ## File path: docs/api/python/gluon/text.md ## @@ -0,0 +1,332 @@ +# Gluon Text API + +## Overview + +The

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643223 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-14 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174643415 ## File path: python/mxnet/gluon/text/vocab.py ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation

[GitHub] eric-haibin-lin commented on issue #10112: [MXNET-16] [DO NOT MERGE] Move submodules to 3rdparty

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #10112: [MXNET-16] [DO NOT MERGE] Move submodules to 3rdparty URL: https://github.com/apache/incubator-mxnet/pull/10112#issuecomment-373212201 @marcoabreu do you know why this happens on CI? ``` GitHub has been notified of this commit’s build result

[GitHub] eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API URL: https://github.com/apache/incubator-mxnet/issues/9921#issuecomment-373211716 @zheng-da I don't quite understand how you could save the memory this way. With kvstore, the `row_sparse` weight is

[GitHub] eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API URL: https://github.com/apache/incubator-mxnet/issues/9921#issuecomment-373211716 @zheng-da I don't quite don't understand how you could save the memory this way. With kvstore, the `row_sparse`

[incubator-mxnet] 07/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 48c15e81637529d4286fb5221cafd8c9b1893455 Author: Olivier AuthorDate: Fri Mar 9

[incubator-mxnet] 05/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit fe814f741e0670c5141ed75e093f4a9de4493dd7 Author: Olivier AuthorDate: Thu Mar 8

[incubator-mxnet] branch cython updated (d2cbda8 -> ffde373)

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a change to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. omit d2cbda8 [WIP] Test CI build (#10111) omit 7c91986 cython timing tests omit 8e6d4bd cython

[incubator-mxnet] 10/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 60dd961e9404bde52eea2b8d3fe1a5cf90aea3de Author: Olivier AuthorDate: Fri Mar 9

[incubator-mxnet] 04/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 6b51a5bd100035ab07056432e050d731b1a0ec4b Author: Olivier AuthorDate: Thu Mar 8

[incubator-mxnet] 08/11: Ignore cything built files

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit b937244a7549b21dd81b58f3ab82c3a3a472b820 Author: Olivier AuthorDate: Fri Mar 9

[incubator-mxnet] 06/11: test calling printf in C++ and C++ class

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 620c9916f3c7b5547d8a106b5356abbf722c8110 Author: Olivier AuthorDate: Thu Mar 8

[incubator-mxnet] 01/11: Refreshed branch cython

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 2fee93e23e58733d7022d9afe153eafe8438af59 Author: Olivier AuthorDate: Thu Mar 8

[incubator-mxnet] 03/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 4b57c36c7e9cf7b44bbb224a49fa72d1f418a289 Author: Olivier AuthorDate: Thu Mar 8

[incubator-mxnet] 02/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 9a6cfccef04440aeb4f2cb3c5ed9c990cd797876 Author: Olivier AuthorDate: Thu Mar 8

[incubator-mxnet] 09/11: cython timing tests

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit bf29e3940554603a2a4597404035895697a1e443 Author: Olivier AuthorDate: Fri Mar 9

[incubator-mxnet] 11/11: [WIP] Test CI build (#10111)

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit ffde37380a323b746716e09eabe1398801020218 Author: Chris Olivier AuthorDate: Wed Mar

[GitHub] eric-haibin-lin commented on issue #9919: Update PR Template

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #9919: Update PR Template URL: https://github.com/apache/incubator-mxnet/pull/9919#issuecomment-373207185 Done. Although I'm a little bit worried that all these reminders make the template kind of heavy

[GitHub] cjolivier01 opened a new pull request #10117: Mycython

2018-03-14 Thread GitBox
cjolivier01 opened a new pull request #10117: Mycython URL: https://github.com/apache/incubator-mxnet/pull/10117 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Changes

[GitHub] thinksanky opened a new pull request #59: Fixed Learn More to the correct landing page

2018-03-14 Thread GitBox
thinksanky opened a new pull request #59: Fixed Learn More to the correct landing page URL: https://github.com/apache/incubator-mxnet-site/pull/59 ## Description ## * Update index.html and direct to the copied location of "why_mxnet.html" in the faq folder. * Redirect the old

[GitHub] eric-haibin-lin commented on a change in pull request #10081: [MXNET-82] [WIP] Sparse op tutorial for developers

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10081: [MXNET-82] [WIP] Sparse op tutorial for developers URL: https://github.com/apache/incubator-mxnet/pull/10081#discussion_r174634024 ## File path: docs/how_to/add_sparse_op_in_backend.md ## @@ -0,0 +1,457 @@ +#

[GitHub] Jerryzcn commented on issue #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
Jerryzcn commented on issue #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#issuecomment-373190338 I used ``` for (int64_t ji = 0; ji < length; ++ji) { int64_t j = ji / h_channel; // batch dim int64_t i = ji

[GitHub] eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174623231 ## File path: python/mxnet/profiler.py ## @@ -35,13

[GitHub] eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#discussion_r174622615 ## File path: src/operator/rnn.cc ## @@ -21,38 +21,212 @@ * Copyright (c) 2015 by

[GitHub] eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#discussion_r174622656 ## File path: src/operator/rnn-inl.h ## @@ -125,418 +175,385 @@ struct RNNParam : public

[GitHub] eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#discussion_r174622720 ## File path: src/operator/rnn-inl.h ## @@ -125,418 +175,385 @@ struct RNNParam : public

[GitHub] eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#discussion_r174622461 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -1540,6 +1548,7 @@ def

[GitHub] eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU

2018-03-14 Thread GitBox
eric-haibin-lin commented on a change in pull request #10104: [WIP] Fused RNN implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10104#discussion_r174622363 ## File path: tests/python/unittest/test_operator.py ## @@ -27,6 +27,83 @@ from common

[GitHub] cjolivier01 commented on a change in pull request #10116: [MXNET-105][WIP] Fix CuDNN performance after code refactor

2018-03-14 Thread GitBox
cjolivier01 commented on a change in pull request #10116: [MXNET-105][WIP] Fix CuDNN performance after code refactor URL: https://github.com/apache/incubator-mxnet/pull/10116#discussion_r174622293 ## File path: src/operator/nn/batch_norm.cu ## @@ -690,12 +690,16 @@ void

[GitHub] Jerryzcn commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-14 Thread GitBox
Jerryzcn commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-373186979 segfault seems to related to https://github.com/apache/incubator-mxnet/pull/10096

[GitHub] eric-haibin-lin closed issue #8635: How to make my own customized transformers

2018-03-14 Thread GitBox
eric-haibin-lin closed issue #8635: How to make my own customized transformers URL: https://github.com/apache/incubator-mxnet/issues/8635 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] eric-haibin-lin commented on issue #8635: How to make my own customized transformers

2018-03-14 Thread GitBox
eric-haibin-lin commented on issue #8635: How to make my own customized transformers URL: https://github.com/apache/incubator-mxnet/issues/8635#issuecomment-373186781 Closing due to inactivity. Feel free to reopen if not resolved yet

[GitHub] zheng-da commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
zheng-da commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373181799 it should work now. This is an automated message from the Apache Git Service. To

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
szha commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373179591 This needs to be fixed. This is an automated message from the Apache Git Service. To

[GitHub] zheng-da commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
zheng-da commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373178452 Yes, it's weird. We don't need to rebuild mkldnn every time in Linux. This is an

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
szha commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373176486 Does the current logic require re-building mkldnn at every `make`? Is caching the build artifact possible?

[GitHub] szha commented on issue #10113: Fix error in ImageIter example in docs

2018-03-14 Thread GitBox
szha commented on issue #10113: Fix error in ImageIter example in docs URL: https://github.com/apache/incubator-mxnet/pull/10113#issuecomment-373176048 Thanks! Remember to add yourself to the contributor list :) This is an

[GitHub] zheng-da commented on a change in pull request #10116: [MXNET-105][WIP] Fix CuDNN performance after code refactor

2018-03-14 Thread GitBox
zheng-da commented on a change in pull request #10116: [MXNET-105][WIP] Fix CuDNN performance after code refactor URL: https://github.com/apache/incubator-mxnet/pull/10116#discussion_r174611191 ## File path: src/operator/nn/batch_norm.cu ## @@ -690,12 +690,16 @@ void

[GitHub] cjolivier01 closed pull request #10111: [WIP] Test CI build

2018-03-14 Thread GitBox
cjolivier01 closed pull request #10111: [WIP] Test CI build URL: https://github.com/apache/incubator-mxnet/pull/10111 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-mxnet] branch cython updated: [WIP] Test CI build (#10111)

2018-03-14 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch cython in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/cython by this push: new d2cbda8 [WIP] Test CI build

[GitHub] zheng-da commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
zheng-da commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373174844 I tested it. It works fine. This is an automated message from the Apache Git Service.

[GitHub] szha commented on issue #10115: Compile MKLDNN in Mac.

2018-03-14 Thread GitBox
szha commented on issue #10115: Compile MKLDNN in Mac. URL: https://github.com/apache/incubator-mxnet/pull/10115#issuecomment-373172868 Given that our CI doesn't have mac yet, please verify the new logic locally. This is an

[GitHub] nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-14 Thread GitBox
nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174607772 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Predictor.scala ## @@ -0,0 +1,188 @@

  1   2   3   >