[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-02-05 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r375606358 ## File path: benchmark/opperf/utils/op_registry_utils.py ## @@ -279,9 +280,9 @@ def g

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-02-05 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r375605955 ## File path: benchmark/opperf/rules/default_params.py ## @@ -152,7 +158,13 @@

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-01-31 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373754277 ## File path: benchmark/opperf/utils/op_registry_utils.py ## @@ -223,13 +223,16 @@ def

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-01-31 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373754176 ## File path: benchmark/opperf/nd_operations/random_sampling_operators.py ## @@ -19,12

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-01-31 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373754190 ## File path: benchmark/opperf/rules/default_params.py ## @@ -58,6 +58,11 @@ DEFAULT_

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-01-31 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373753403 ## File path: benchmark/opperf/utils/op_registry_utils.py ## @@ -223,13 +226,17 @@ def

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-01-31 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373753338 ## File path: benchmark/opperf/utils/op_registry_utils.py ## @@ -23,8 +23,7 @@ from b

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops

2020-01-31 Thread GitBox
ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373753313 ## File path: benchmark/opperf/nd_operations/random_sampling_operators.py ## @@ -19,12