[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18478: [v1.7.x]License checker enhancement

2020-06-23 Thread GitBox
ChaiBapchya commented on pull request #18478: URL: https://github.com/apache/incubator-mxnet/pull/18478#issuecomment-648312575 Thanks for driving this. Looks like fixing numpy version helped resolve other pipeline issues [barring windows-cpu] @leezu any thoughts?

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18478: [v1.7.x]License checker enhancement

2020-06-19 Thread GitBox
ChaiBapchya commented on pull request #18478: URL: https://github.com/apache/incubator-mxnet/pull/18478#issuecomment-646932085 Right. Instead of my suggestion of skipping the tests; adding it that way is better. Thanks for that one @leezu

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18478: [v1.7.x]License checker enhancement

2020-06-19 Thread GitBox
ChaiBapchya commented on pull request #18478: URL: https://github.com/apache/incubator-mxnet/pull/18478#issuecomment-646798588 @ciyongch Can you update the `license_header.py` to ignore files in `/.github` folder? So that it passes the sanity & we can fix this PR? Also you'd have to