ChaiBapchya opened a new pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542 ## Description ## Adds following ops to OpPerf [once all the OpPerf PRs get merged, all MXNet ops in NDArray namespace will be completed in OpPerf coverage (minus deprecated, _contrib ops and few other ops with known issues)] - norm op to reduction category - Following Optimizer ops - mp_nag_mom - nag_mom - lambd_update_phase_1 and 2 - preloaded_multi_* - multi_* - Cast ops - cast - amp_cast - amp_multicast ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - [ ] Code is well-documented: - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ## Comments ## Ops falling in the category of multi_* and preloaded_multi_* were notorious They don't have standard keyworded arguments (data=data) They expect variable positional args (*data) It was previously handled such that only 1 value of variable positional arg could be passed Now, you can pass as many values for positional args as you want. However for running run_performance_test, inputs have to be key:value pair That is handled as args0, args1, arg2, etc So as long as the name of the key starts with args it will be considered as input for the operator. This is a very rare case that the user doesn't take keyworded args. Most other ops in MXNet NDArray namespace take keyworded args.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
