Kh4L commented on a change in pull request #17222: fix flaky test: boolean
index and fix bugs
URL: https://github.com/apache/incubator-mxnet/pull/17222#discussion_r363379075
##########
File path: tests/python/unittest/test_numpy_op.py
##########
@@ -1296,10 +1296,9 @@ def hybrid_forward(self, F, a, mask, value):
for hybridize in [False]:
for config in configs:
- print(config)
dshape, mshape, start_axis = config
test_data = np.random.uniform(size=dshape)
- mx_mask = np.around(np.random.uniform(size=mshape))
+ mx_mask = np.around(np.random.uniform(size=mshape)).astype(np.bool)
Review comment:
Nitpicking:
```suggestion
mx_mask = np.random.choice(a=[False, True], size=mshape)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
