[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-25 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r350381992 ## File path: src/operator/optimizer_op-inl.h ## @@ -1563,6 +1563,192 @@ inline void AdamUpdateEx(const

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-22 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r349745221 ## File path: python/mxnet/optimizer/optimizer.py ## @@ -1244,6 +1244,54 @@ def update(self, index, weight,

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-22 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r349744815 ## File path: src/operator/optimizer_op-inl.h ## @@ -1563,6 +1563,192 @@ inline void AdamUpdateEx(const

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-22 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r349744737 ## File path: src/operator/optimizer_op-inl.h ## @@ -1563,6 +1563,192 @@ inline void AdamUpdateEx(const

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346107803 ## File path: src/operator/optimizer_op.cc ## @@ -921,5 +923,39 @@ Note that non-zero values for the weight

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346107263 ## File path: src/operator/optimizer_op-inl.h ## @@ -1563,6 +1563,192 @@ inline void AdamUpdateEx(const

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346107327 ## File path: tests/python/unittest/test_optimizer.py ## @@ -425,6 +425,77 @@ def test_nag():

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346088876 ## File path: src/operator/optimizer_op.cc ## @@ -921,5 +923,33 @@ Note that non-zero values for the weight

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346088727 ## File path: python/mxnet/optimizer/optimizer.py ## @@ -1244,6 +1244,51 @@ def update(self, index, weight,

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346088445 ## File path: tests/python/unittest/test_optimizer.py ## @@ -425,6 +425,77 @@ def test_nag():

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346088325 ## File path: src/operator/optimizer_op.cc ## @@ -921,5 +923,33 @@ Note that non-zero values for the weight

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #16715: Lamb optimizer update

2019-11-13 Thread GitBox
access2rohit commented on a change in pull request #16715: Lamb optimizer update URL: https://github.com/apache/incubator-mxnet/pull/16715#discussion_r346088464 ## File path: tests/python/unittest/test_optimizer.py ## @@ -425,6 +425,77 @@ def test_nag():