[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #16408: Add MXNet Ops for fast multihead attention

2019-10-22 Thread GitBox
eric-haibin-lin commented on a change in pull request #16408: Add MXNet Ops for fast multihead attention URL: https://github.com/apache/incubator-mxnet/pull/16408#discussion_r337861997 ## File path: src/operator/contrib/transformer-inl.h ## @@ -34,6 +34,18 @@ namespace mx

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #16408: Add MXNet Ops for fast multihead attention

2019-10-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #16408: Add MXNet Ops for fast multihead attention URL: https://github.com/apache/incubator-mxnet/pull/16408#discussion_r335803864 ## File path: src/operator/contrib/transformer.cc ## @@ -29,6 +29,231 @@ namespace mxne

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #16408: Add MXNet Ops for fast multihead attention

2019-10-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #16408: Add MXNet Ops for fast multihead attention URL: https://github.com/apache/incubator-mxnet/pull/16408#discussion_r335803364 ## File path: src/operator/contrib/transformer.cc ## @@ -29,6 +29,231 @@ namespace mxne