[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383026630 ## File path: src/api/api_npi.cc ## @@ -0,0 +1,181 @@ +/* Review comment: Agree. I

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383025838 ## File path: src/api/api_npi.cc ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383025807 ## File path: src/api/api_npi.cc ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383025780 ## File path: python/mxnet/_ffi/_ctypes/types.py ## @@ -0,0 +1,58 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383025775 ## File path: include/mxnet/runtime/ffi_helper.h ## @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383025749 ## File path: include/mxnet/runtime/ffi_helper.h ## @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-23 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r383025689 ## File path: include/mxnet/runtime/object.h ## @@ -0,0 +1,823 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-19 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r381179420 ## File path: ci/jenkins/Jenkins_steps.groovy ## @@ -24,23 +24,23 @@ utils =

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-19 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r381170806 ## File path: src/api/api_lang.cc ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-19 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r381170450 ## File path: python/mxnet/_ffi/runtime_ctypes.py ## @@ -0,0 +1,30 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-19 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r381170174 ## File path: python/mxnet/_ffi/_cy2/__init__.py ## @@ -0,0 +1,17 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-19 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r381170239 ## File path: python/mxnet/_ffi/function.py ## @@ -0,0 +1,166 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-17 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r380088099 ## File path: include/mxnet/runtime/packed_func.h ## @@ -0,0 +1,1254 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-16 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r379994604 ## File path: include/mxnet/runtime/packed_func.h ## @@ -0,0 +1,1254 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation

2020-02-16 Thread GitBox
hzfan commented on a change in pull request #17510: MXNet FFI for Operator Imperative Invocation URL: https://github.com/apache/incubator-mxnet/pull/17510#discussion_r379994604 ## File path: include/mxnet/runtime/packed_func.h ## @@ -0,0 +1,1254 @@ +/* + * Licensed to the