[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #18197: [Numpy] Add qr backward part 2 for wide matrices with m < n

2020-05-15 Thread GitBox
hzfan commented on a change in pull request #18197: URL: https://github.com/apache/incubator-mxnet/pull/18197#discussion_r425852127 ## File path: src/operator/numpy/linalg/np_qr-inl.h ## @@ -542,36 +591,119 @@ void QrBackwardImpl(const TBlob& grad_a, const

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #18197: [Numpy] Add qr backward part 2 for wide matrices with m < n

2020-05-14 Thread GitBox
hzfan commented on a change in pull request #18197: URL: https://github.com/apache/incubator-mxnet/pull/18197#discussion_r424862190 ## File path: src/operator/numpy/linalg/np_qr-inl.h ## @@ -514,15 +548,28 @@ struct qr_backward { template size_t QrBackwardWorkspaceSize(cons

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #18197: [Numpy] Add qr backward part 2 for wide matrices with m < n

2020-05-14 Thread GitBox
hzfan commented on a change in pull request #18197: URL: https://github.com/apache/incubator-mxnet/pull/18197#discussion_r424862190 ## File path: src/operator/numpy/linalg/np_qr-inl.h ## @@ -514,15 +548,28 @@ struct qr_backward { template size_t QrBackwardWorkspaceSize(cons