[GitHub] [incubator-mxnet] larroy commented on issue #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result

2019-06-18 Thread GitBox
larroy commented on issue #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result URL: https://github.com/apache/incubator-mxnet/pull/15262#issuecomment-503318341 thanks for fixing this, and it's cool that your orginal commit enables dynamic shape.

[GitHub] [incubator-mxnet] larroy commented on issue #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result

2019-06-18 Thread GitBox
larroy commented on issue #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result URL: https://github.com/apache/incubator-mxnet/pull/15262#issuecomment-503317990 So the root cause of the degradation was the additional shape inferencing passes?

[GitHub] [incubator-mxnet] larroy commented on issue #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result

2019-06-18 Thread GitBox
larroy commented on issue #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result URL: https://github.com/apache/incubator-mxnet/pull/15262#issuecomment-503317603 @junrushao1994 would have been nice that you tagged me for review as well, since I was looking into this