[GitHub] [incubator-mxnet] leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds

2020-02-26 Thread GitBox
leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds URL: https://github.com/apache/incubator-mxnet/pull/17645#issuecomment-591552783 @cjolivier01 I'll remove the MKL fix and testing MKL builds from this PR and you can contribute a separate PR that fixe

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds

2020-02-26 Thread GitBox
leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds URL: https://github.com/apache/incubator-mxnet/pull/17645#issuecomment-591531288 @cjolivier01 this PR fails without fixing OMP. That's because the CI previously didn't test cmake OMP. In any se

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds

2020-02-21 Thread GitBox
leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds URL: https://github.com/apache/incubator-mxnet/pull/17645#issuecomment-589798230 What do you mean? The CI is testing this PR. dev environment is for changes to the CI itself. This doesn't touch the CI

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds

2020-02-20 Thread GitBox
leezu edited a comment on issue #17645: [CI] Test CMake builds instead of Makefile builds URL: https://github.com/apache/incubator-mxnet/pull/17645#issuecomment-589528150 @apeforest I agree the TVM Op testing can be improved. I'll first attempt to make this PR pass CI, without changing any