leezu opened a new pull request #17229: Fix and clean up Ubuntu build from 
source instructions
URL: https://github.com/apache/incubator-mxnet/pull/17229
 
 
   ## Description ##
   Fix and clean up Ubuntu build from source instructions.
   
   Fixes https://github.com/apache/incubator-mxnet/issues/17226
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Simplify and fix Ubuntu build from source instructions
   
   ## Comments ##
   Justification for respective removals
   - Binary Python install instructions: 1) The instructions were outdated and 
incomplete 2) This is a "Build From Source Guide". Why include binary package 
install instructions? 3) There are better instructions for the binary python 
install at the Get Started Page. Thus link to that page instead.
   - `ci/docker/install/ubuntu_{core,python}.sh` "quick" install: 1) 
https://github.com/apache/incubator-mxnet/issues/17226 2) Only supports Ubuntu 
16.04
   - `./install_mxnet_ubuntu_python.sh`: Does not exist anymore
   - `dev_menu.py build`: The `dev_menu.py build` does things differently 
compared to the simple build instructions in this tutorial. For example, it 
uses virtualenv and contains other unrelated features such as building docker 
containers. I think it adds confusion for new users if we include it in the 
setup guide.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to