leezu opened a new pull request #17582: Fix Apache RAT License check URL: https://github.com/apache/incubator-mxnet/pull/17582 ## Description ## There are several issues this PR attempts to address (but still WIP): 1) ``` Binary files (which do not require any license headers) will be marked B [2020-02-10T20:00:33.314Z] B /work/mxnet/tests/python-pytest/onnx/README.md [2020-02-10T20:00:33.308Z] B /work/mxnet/julia/docs/src/api/optimizer.md ``` is wrong on CI, but these files are correctly detected as lacking license headers on my local machine. 2) `rat-exclude` file doesn't work currently. For example `cmake/Modules/FindCUDAToolkit.cmake` is part of rat-exclude, but rat still attempts to test the file. It reports on the CI [2020-02-12T19:59:53.974Z] MIT /work/mxnet/cmake/Modules/FindCUDAToolkit.cmake 3) Build from source only works with JDK < 9 due to dependency on maven-compiler-plugin and `make ratcheck` is thus broken on newer systems. ## Comments ## @roywei @szha
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
