samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-562375617
> Hi @samskalicky and @rondogency , is it ready to merge this PR after CI
passes?
Yes! We're soo ready to merge :)
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-543775483
pipeline timed out, for centos-cpu, had to push again.
This is an
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-543632838
More flaky test failures:
```
==
FAIL:
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-543570416
Thanks @wkcn, i ran into some flaky test failures and had to push another
empty commit:
```
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-543515556
@yzhliu any idea why this is failing?
```
Traceback (most recent call last):
File "/work/mxnet/contrib/tvmop/compile.py", line
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-541983523
> Just talked with @szha and he found out a better way to make `MXTensor`
not diverge from the de facto standard tensor format `DLTensor`
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-540242870
Note: the two failing CI jobs are related to numpy:
sanity:
```
* Module mxnet.numpy_op_signature
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-539344942
> Hey, thank you guys for the nice work! BTW, would you mind if you guys
clearly state why DLTensor is not adopted, which I believe would
samskalicky commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-537741566
Failing centos-gpu job is failing with Numpy issue #16358 unrelated to this
PR. We've sync'ed with the authors and they confirmed. Assume