[GitHub] [incubator-mxnet] samskalicky commented on issue #15969: [WIP] Partitioning Gluon HybridBlocks

2020-01-22 Thread GitBox
samskalicky commented on issue #15969: [WIP] Partitioning Gluon HybridBlocks URL: https://github.com/apache/incubator-mxnet/pull/15969#issuecomment-577454098 @eric-haibin-lin we shouldnt partition inside `_get_graph` since its also called here:

[GitHub] [incubator-mxnet] samskalicky commented on issue #15969: [WIP] Partitioning Gluon HybridBlocks

2020-01-22 Thread GitBox
samskalicky commented on issue #15969: [WIP] Partitioning Gluon HybridBlocks URL: https://github.com/apache/incubator-mxnet/pull/15969#issuecomment-577450050 Thanks @guanxinq for the latest update! I think we need to call optimize for again here too when we create a SymbolBlock, otherwise

[GitHub] [incubator-mxnet] samskalicky commented on issue #15969: [WIP] Partitioning Gluon HybridBlocks

2019-08-23 Thread GitBox
samskalicky commented on issue #15969: [WIP] Partitioning Gluon HybridBlocks URL: https://github.com/apache/incubator-mxnet/pull/15969#issuecomment-524430581 Waiting on #15886 to be merged to re-use optimize_for API call on symbol