szha commented on issue #16294: Add CMake flag `CMAKE_BUILD_TYPE=Release`
URL: https://github.com/apache/incubator-mxnet/pull/16294#issuecomment-536708927
 
 
   It makes sense to use release build by default, though we should still 
document the usage of debug build in developer guide.
   
   The debug build issue should definitely be investigated. However, given that 
the debug build has issues regardless of the changes in this PR, the 
investigation of the bug should not be a blocker for this change.
   
   #9516 seems to be an appropriate issue for investigation on nvcc debug mode. 
@hgt312 @reminisce @haojin2 it would be great if you could document what you've 
seen in that issue. @ptrendx @DickJC123 feel free to comment there with any 
insight you have.
   
   @marcoabreu does that sound good? Do you have other technical reasons that 
make you believe the PR should be stopped?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to