zixuanweeei edited a comment on issue #17632: [Large Tensor] Fixed RNN op URL: https://github.com/apache/incubator-mxnet/pull/17632#issuecomment-593045926 > @zixuanweeei Could you please take a look at the changes? Seems need coordinate with the changes in #17702. Let's wait for @connorgoggins updating type to `size_t` for some variables representing the size and his feedback. Overall looks good. We can get this merged first. Due to the fact that the `hidden_size`/`state_size` are still remaining to `int` type, I think there is not much stuff to do for `projection_size` if no further concern.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
