[GitHub] CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version

2018-01-30 Thread GitBox
CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-361818280 @cjolivier01 @eric-haibin-lin @yzhliu since we have cut out 1.1 branch, is it ready to merge this to master?

[GitHub] CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version

2018-01-22 Thread GitBox
CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-359656699 ping @eric-haibin-lin This is an automated message from

[GitHub] CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version

2018-01-20 Thread GitBox
CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-359224549 @eric-haibin-lin @cjolivier01 what's the current agreement for this? I do not mind merging it after 1.0.1 release.

[GitHub] CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version

2018-01-17 Thread GitBox
CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-358483940 most of changes would be on spark part, the following changes is planned to be made after this is merged or as you said do

[GitHub] CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version

2018-01-17 Thread GitBox
CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-358400615 @eric-haibin-lin the original idea is for spark integration, as the current one-worker-per-process makes it hard to

[GitHub] CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version

2018-01-15 Thread GitBox
CodingCat commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-357821864 @eric-haibin-lin the test case was added in ps-lite repo, for mxnet repo, my plan is to add in scala-packages/spark which