[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-05 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222948018 ## File path: tests/python/mkl/test_subgraph.py ## @@ -0,0 +1,472 @@ +#

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-05 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222947557 ## File path: src/c_api/c_api_symbolic.cc ## @@ -696,3 +696,21 @@ int

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-05 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222943278 ## File path: src/ndarray/ndarray.cc ## @@ -1592,8 +1601,12 @@ void

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-04 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222583387 ## File path: tests/python/mkl/test_subgraph.py ## @@ -0,0 +1,472 @@ +#

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-04 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222582000 ## File path: src/operator/quantization/mkldnn/mkldnn_quantize-inl.h ## @@

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-04 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222580648 ## File path: src/ndarray/ndarray.cc ## @@ -1592,8 +1601,12 @@ void

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-04 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222580110 ## File path: src/c_api/c_api_symbolic.cc ## @@ -696,3 +696,21 @@ int

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-04 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222577892 ## File path: python/mxnet/contrib/quantization.py ## @@ -53,6 +53,7 @@ def

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-04 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222576926 ## File path: python/mxnet/contrib/quantization.py ## @@ -40,7 +40,7 @@

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-02 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221867338 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-02 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221866332 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

2018-10-02 Thread GitBox
KellenSunderland commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221862468 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@