anirudh2290 closed pull request #13045: la_op_inline.h to la_op-inl.h for
consistency
URL: https://github.com/apache/incubator-mxnet/pull/13045
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/operator/linalg_impl.h b/src/operator/linalg_impl.h
index c0ae97ad3a4..d7c3c651916 100644
--- a/src/operator/linalg_impl.h
+++ b/src/operator/linalg_impl.h
@@ -18,7 +18,7 @@
*/
/*!
- * \file linalg.h
+ * \file linalg_impl.h
* \brief Implementation of unified tensor interface for advanced linear
algebra functions
* (specifically BLAS3/LAPACK) from within mxnet.
*/
diff --git a/src/operator/tensor/control_flow_op.h
b/src/operator/tensor/control_flow_op.h
index e9aa9f63fae..07252963c87 100644
--- a/src/operator/tensor/control_flow_op.h
+++ b/src/operator/tensor/control_flow_op.h
@@ -19,7 +19,7 @@
/*!
* Copyright (c) 2017 by Contributors
- * \file control_flow.h
+ * \file control_flow_op.h
* \brief Function definitions of operators for controlling flow
*/
#ifndef MXNET_OPERATOR_TENSOR_CONTROL_FLOW_OP_H_
diff --git a/src/operator/tensor/elemwise_binary_broadcast_op_basic.cc
b/src/operator/tensor/elemwise_binary_broadcast_op_basic.cc
index 8583702e15f..6d3ce933af8 100644
--- a/src/operator/tensor/elemwise_binary_broadcast_op_basic.cc
+++ b/src/operator/tensor/elemwise_binary_broadcast_op_basic.cc
@@ -19,8 +19,8 @@
/*!
* Copyright (c) 2016 by Contributors
- * \file elemwise_binary_scalar_op.cc
- * \brief CPU Implementation of binary function.
+ * \file elemwise_binary_broadcast_op_basic.cc
+ * \brief CPU Implementation of basic functions for elementwise binary
broadcast operator.
*/
#include "./elemwise_unary_op.h"
#include "./elemwise_binary_op.h"
diff --git a/src/operator/tensor/elemwise_binary_broadcast_op_basic.cu
b/src/operator/tensor/elemwise_binary_broadcast_op_basic.cu
index 6231d037d8d..aa0850ac5bb 100644
--- a/src/operator/tensor/elemwise_binary_broadcast_op_basic.cu
+++ b/src/operator/tensor/elemwise_binary_broadcast_op_basic.cu
@@ -19,8 +19,8 @@
/*!
* Copyright (c) 2016 by Contributors
- * \file elemwise_binary_scalar_op.cu
- * \brief GPU Implementation of binary function.
+ * \file elemwise_binary_broadcast_op_basic.cu
+ * \brief GPU Implementation of basic functions for elementwise binary
broadcast operator.
*/
#include "./elemwise_unary_op.h"
#include "./elemwise_binary_op.h"
diff --git a/src/operator/tensor/elemwise_binary_broadcast_op_extended.cu
b/src/operator/tensor/elemwise_binary_broadcast_op_extended.cu
index ea527bea904..e8e79f726b6 100644
--- a/src/operator/tensor/elemwise_binary_broadcast_op_extended.cu
+++ b/src/operator/tensor/elemwise_binary_broadcast_op_extended.cu
@@ -19,7 +19,7 @@
/*!
* Copyright (c) 2016 by Contributors
- * \file elemwise_binary_scalar_op.cu
+ * \file elemwise_binary_broadcast_op_extended.cu
* \brief GPU Implementation of extended functions for elementwise binary
broadcast operator.
*/
#include "./elemwise_unary_op.h"
diff --git a/src/operator/tensor/elemwise_binary_broadcast_op_logic.cu
b/src/operator/tensor/elemwise_binary_broadcast_op_logic.cu
index 0a12212a44b..4bec07b7096 100644
--- a/src/operator/tensor/elemwise_binary_broadcast_op_logic.cu
+++ b/src/operator/tensor/elemwise_binary_broadcast_op_logic.cu
@@ -19,7 +19,7 @@
/*!
* Copyright (c) 2016 by Contributors
- * \file elemwise_binary_scalar_op.cu
+ * \file elemwise_binary_broadcast_op_logic.cu
* \brief GPU Implementation of elementwise binary broadcast logical operators.
*/
#include "./elemwise_unary_op.h"
diff --git a/src/operator/tensor/elemwise_binary_op_extended.cc
b/src/operator/tensor/elemwise_binary_op_extended.cc
index 26d429c5331..53c0b5c057d 100644
--- a/src/operator/tensor/elemwise_binary_op_extended.cc
+++ b/src/operator/tensor/elemwise_binary_op_extended.cc
@@ -19,8 +19,8 @@
/*!
* Copyright (c) 2016 by Contributors
- * \file elemwise_binary_scalar_op.cc
- * \brief CPU Implementation of unary function.
+ * \file elemwise_binary_op_extended.cc
+ * \brief CPU Implementation of extended functions for elementwise binary
broadcast operator..
*/
#include "./elemwise_unary_op.h"
#include "./elemwise_binary_op-inl.h"
diff --git a/src/operator/tensor/elemwise_scatter_op.h
b/src/operator/tensor/elemwise_scatter_op.h
index 33bc0da8ae2..0e52a86da8b 100644
--- a/src/operator/tensor/elemwise_scatter_op.h
+++ b/src/operator/tensor/elemwise_scatter_op.h
@@ -18,7 +18,7 @@
*/
/*!
- * \file elementwise_scatter_op.h
+ * \file elemwise_scatter_op.h
* \brief Function definition of elementwise scatter operators
*/
#ifndef MXNET_OPERATOR_TENSOR_ELEMWISE_SCATTER_OP_H_
diff --git a/src/operator/tensor/la_op_inline.h
b/src/operator/tensor/la_op-inl.h
similarity index 99%
rename from src/operator/tensor/la_op_inline.h
rename to src/operator/tensor/la_op-inl.h
index b483108970a..b3353e285c7 100644
--- a/src/operator/tensor/la_op_inline.h
+++ b/src/operator/tensor/la_op-inl.h
@@ -19,11 +19,11 @@
/*!
* Copyright (c) 2017 by Contributors
- * \file la_op_inline.h
+ * \file la_op-inl.h
* \brief Operators for advanced linear algebra.
*/
-#ifndef MXNET_OPERATOR_TENSOR_LA_OP_INLINE_H_
-#define MXNET_OPERATOR_TENSOR_LA_OP_INLINE_H_
+#ifndef MXNET_OPERATOR_TENSOR_LA_OP_INL_H_
+#define MXNET_OPERATOR_TENSOR_LA_OP_INL_H_
#include "../linalg.h"
@@ -672,4 +672,4 @@ struct syevd_backward {
} // namespace op
} // namespace mxnet
-#endif // MXNET_OPERATOR_TENSOR_LA_OP_INLINE_H_
+#endif // MXNET_OPERATOR_TENSOR_LA_OP_INL_H_
diff --git a/src/operator/tensor/la_op.cc b/src/operator/tensor/la_op.cc
index e54e0682713..91bcdd314d8 100644
--- a/src/operator/tensor/la_op.cc
+++ b/src/operator/tensor/la_op.cc
@@ -23,7 +23,7 @@
* \brief CPU implementation of Operators for advanced linear algebra.
*/
#include "./la_op.h"
-#include "./la_op_inline.h"
+#include "./la_op-inl.h"
namespace mxnet {
namespace op {
diff --git a/src/operator/tensor/la_op.cu b/src/operator/tensor/la_op.cu
index da81c040bff..29a48466313 100644
--- a/src/operator/tensor/la_op.cu
+++ b/src/operator/tensor/la_op.cu
@@ -22,7 +22,7 @@
* \brief GPU implementation of Operators for advanced linear algebra.
*/
#include "./la_op.h"
-#include "./la_op_inline.h"
+#include "./la_op-inl.h"
namespace mxnet {
namespace op {
diff --git a/src/operator/tensor/ordering_op-inl.h
b/src/operator/tensor/ordering_op-inl.h
index c076f90d7a8..1847a533d6e 100644
--- a/src/operator/tensor/ordering_op-inl.h
+++ b/src/operator/tensor/ordering_op-inl.h
@@ -20,7 +20,7 @@
/*!
* Copyright (c) 2016 by Contributors
* \file ordering_op-inl.h
- * \brief Function definition of matrix related operators
+ * \brief Function definition of ordering operators
*/
#ifndef MXNET_OPERATOR_TENSOR_ORDERING_OP_INL_H_
#define MXNET_OPERATOR_TENSOR_ORDERING_OP_INL_H_
diff --git a/src/operator/tensor/ordering_op.cu
b/src/operator/tensor/ordering_op.cu
index 8ffcd6e3ac7..db47913e9f8 100644
--- a/src/operator/tensor/ordering_op.cu
+++ b/src/operator/tensor/ordering_op.cu
@@ -20,7 +20,7 @@
/*!
* Copyright (c) 2015 by Contributors
* \file ordering_op.cu
- * \brief GPU Implementation of matrix operations
+ * \brief GPU Implementation of ordering operations
*/
// this will be invoked by gcc and compile GPU version
#include "./ordering_op-inl.h"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
